Skip to content

Goreleaser s3 upload not working #1243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dopey merged 6 commits into from
Jul 23, 2024
Merged

Goreleaser s3 upload not working #1243

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c3386a6
[ci] Fix upload of release build artifacts to s3
dopey Jul 23, 2024
149f52e
Shut off ci while testing
dopey Jul 23, 2024
16a07be
Be explicit with extra_files and glob in s3 blobs
dopey Jul 23, 2024
e144602
Reenable ci steps in release workflow
dopey Jul 23, 2024
964f85f
Merge branch 'master' into max/s3-upload
dopey Jul 23, 2024
118d739
Merge branch 'master' into max/s3-upload
tashian Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 19 additions & 6 deletions .goreleaser.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,16 +262,29 @@ release:
# - glob: ./glob/foo/to/bar/file/foobar/override_from_previous

blobs:
-
provider: s3
region: us-east-1
bucket: '{{ .Env.AWS_S3_BUCKET }}'
- provider: s3
disable: 'false'
ids:
- s3-versioned
- s3-unversioned
bucket: '{{ .Env.AWS_S3_BUCKET }}'
region: us-east-1

@maraino maraino Jul 23, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use an environment variable for this too.

directory: '/'
acl: public-read
disable: '{{ ne .Prerelease "" }}'
extra_files:
- glob: ./dist/s3-versioned_*/**
extra_files_only: true

- provider: s3
disable: '{{ if .Prerelease }}true{{ else }}false{{ end }}'
ids:
- s3-unversioned

@maraino maraino Jul 23, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, for now, I think we are building the same binaries twice, we could use name_template in the extra_files to change the name of the s3_versioned files.

bucket: '{{ .Env.AWS_S3_BUCKET }}'
region: us-east-1
directory: '/'
acl: public-read
extra_files:
- glob: ./dist/s3-unversioned_*/**
extra_files_only: true

winget:
-
Expand Down