fix: redirect missing hook remediation links to the current deno starter template - #166
Merged
Merged
Conversation
zimeg
added
bug
zimeg
added
the
semver:patch
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #166 +/- ##
==========================================
- Coverage 62.98% 62.97% -0.01%
==========================================
Files 212 212
Lines 21585 21585
==========================================
- Hits 13595 13594 -1
+ Misses 6946 6945 -1
- Partials 1044 1046 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lukegalbraithrussell
approved these changes
Jul 24, 2025
lukegalbraithrussell
left a comment
lukegalbraithrussell
left a comment
Contributor
There was a problem hiding this comment.
Agreed on putting the spec in the docs, but this is a good fix for now!
mwbrooks
approved these changes
Jul 24, 2025
| ✘ Runtime (foundations for the application) | ||
| Error: The `doctor` hook was not found (sdk_hook_not_found) | ||
| Suggestion: Ensure this hook is implemented in your `slack.json` | ||
| Suggestion: Debug responses from the Slack hooks file (.slack/hooks.json) |
| "", | ||
| "Every app requires a Slack hooks file and you can find an example at:", | ||
| style.Highlight("https://github.com/slack-samples/deno-starter-template/blob/main/slack.json"), | ||
| style.Highlight("https://github.com/slack-samples/deno-starter-template/blob/main/.slack/hooks.json"), |
Member
Author
|
@lukegalbraithrussell @mwbrooks And thank y'all both for the reviews and thoughts on the docs 🙏 ✨ It sounds like excitement for a reference hook spec is shared but we can save that for a follow up PR. For now I'll merge this for next release! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR redirects a link from the
sdk_hook_not_founderror to the current Deno starter template.slack/hooks.jsonfile.Notes
IMO it'd be nice to reference the hooks specification in documentation, but for now this might be an alright link change - I'll start a conversation in channel about this, but please feel free to drop ideas beforehand!
Requirements