Skip to content

feat: output warning of deno removal from installation scripts - #165

Merged
zimeg merged 2 commits into
mainfrom
zimeg-feat-install-deno-deprecation
Jul 23, 2025
Merged

feat: output warning of deno removal from installation scripts#165
zimeg merged 2 commits into
mainfrom
zimeg-feat-install-deno-deprecation

Conversation

@zimeg

@zimeg zimeg commented Jul 23, 2025

Copy link
Copy Markdown
Member

Changelog

Starting September 1, 2025 the Slack CLI installation script will no longer include deno as part of the installation. We recommend installing deno separately and configuring CI systems as needed if deno is used for application development, such as for ROSI apps.

Summary

This PR outputs a warning that deno will be removed from installation scripts at a future date: September 1, 2025.

Preview

warning

Requirements

@zimeg zimeg added this to the Next Release milestone Jul 23, 2025
@zimeg zimeg self-assigned this Jul 23, 2025
@zimeg zimeg added enhancement M-T: A feature request for new functionality changelog Use on updates to be included in the release notes semver:patch Use on pull requests to describe the release version increment build M-T: Changes to compilation and CI processes area:deno-sdk Related to github.com/slackapi/deno-slack-sdk labels Jul 23, 2025
@codecov

codecov Bot commented Jul 23, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.95%. Comparing base (986c433) to head (d9c6327).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #165      +/-   ##
==========================================
- Coverage   62.97%   62.95%   -0.03%     
==========================================
  Files         212      212              
  Lines       21585    21585              
==========================================
- Hits        13594    13589       -5     
- Misses       6945     6948       +3     
- Partials     1046     1048       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zimeg

zimeg commented Jul 23, 2025

Copy link
Copy Markdown
Member Author

🗣️ The output on powershell might match this:

warning

@zimeg

zimeg commented Jul 23, 2025

Copy link
Copy Markdown
Member Author

📝 Open to all comments and suggestions, but I'll mark this as "ready for review" for now with plans to improve error outputs for a missing runtime in a follow up PR!

@zimeg
zimeg marked this pull request as ready for review July 23, 2025 19:18
@zimeg
zimeg requested a review from a team as a code owner July 23, 2025 19:18

@mwbrooks mwbrooks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Looks good to me! Thanks for putting together this PR.

🖥️ Visually, this looks as good as we can hope and I appreciate that you've added some recommended next steps for folks who need to manually install Deno.

⏭️ Can we plan some follow-ups to make sure that the CLI commands error gracefully when Deno is missing and provides a link to docs on how to setup Deno?

@zimeg

zimeg commented Jul 23, 2025

Copy link
Copy Markdown
Member Author

@mwbrooks Thanks so much for the kind review!

I'm hoping this stands out a bit more than other outputs to catch the eye, but I'm also looking forward to removing these lines from the script.

Let's merge this now, but please know I'll begin a fast follow for graceful errors soon. I like the idea of including recommended docs with this! 🚢 💨

@zimeg
zimeg merged commit 40e6863 into main Jul 23, 2025
5 checks passed
@zimeg
zimeg deleted the zimeg-feat-install-deno-deprecation branch July 23, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:deno-sdk Related to github.com/slackapi/deno-slack-sdk build M-T: Changes to compilation and CI processes changelog Use on updates to be included in the release notes enhancement M-T: A feature request for new functionality semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants