docs: Update MAINTAINERS_GUIDE.md with golangci-lint command not found - #163
Merged
Conversation
mwbrooks
added
docs
mwbrooks
changed the title
mwbrooks
marked this pull request as ready for review
July 17, 2025 23:44
zimeg
approved these changes
Jul 18, 2025
Comment on lines
+129
to
+131
| ```bash | ||
| export PATH=$PATH:$(go env GOPATH)/bin | ||
| ``` |
Member
There was a problem hiding this comment.
🗣️ This makes me wish each a $HOME/bin or similar was standard for the $PATH...
Member
Author
|
Thanks for the quick review @zimeg! 🙇🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request updates the
MAINTAINERS_GUIDE.mdwith a troubleshooting step to add the$GOPATH/binto your$PATH.→ Preview MAINTAINERS_GUDIE.md
Honestly, I'm not sure what the best practice is here. The golangci-lint Installation Guide asks you to run a curl command that installs
golangci-lintto your$(go env GOPATH)/bin. However, the default installation of Golang using the.pkgdoesn't configure this path. I imagine this varies depending how Golang was installed, so I've decided to add this as a troubleshooting step.Requirements