Skip to content

fix: revert internal packages requiring esm loading for backward compatible support #2712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zimeg merged 2 commits into from
Aug 27, 2026
Merged

fix: revert internal packages requiring esm loading for backward compatible support #2712

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3bd4240
fix: revert internal packages requiring esm loading for backward comp…
zimeg Aug 27, 2026
f57d723
docs(deps): collapse dependabot ignore comments to one-liners
zimeg Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/restore-cjs-loadable-deps.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@slack/web-api": patch
"@slack/webhook": patch
---

fix: revert internal packages requiring esm loading for backward compatible support ([#2711](https://github.com/slackapi/node-slack-sdk/issues/2711))
13 changes: 10 additions & 3 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,12 @@ updates:
- "@types/mocha"
- "mocha"
ignore:
# p-queue (v7+) and p-retry (v5+) are pure ESM and raise their minimum
# Node.js version each major. Bumping either breaks `require()` of this
# package's CommonJS build on the declared Node >= 20 range (ERR_REQUIRE_ESM,
# see #2711) and can force a change to its supported Node floor.
Comment thread
zimeg marked this conversation as resolved.
Outdated
- dependency-name: "p-queue"
- dependency-name: "p-retry"
- dependency-name: "@types/node"
versions:
- "21.x"
Expand Down Expand Up @@ -215,9 +221,10 @@ updates:
- "@types/mocha"
- "mocha"
ignore:
# p-retry is pure ESM and raises its minimum Node.js version each major
# (v7 requires Node >= 20, v8 requires Node >= 22). Bumping it can force a
# change to this package's own supported Node floor.
# p-retry (v5+) is pure ESM and raises its minimum Node.js version each
# major (v7 requires Node >= 20, v8 requires Node >= 22). Bumping it breaks
# `require()` of this package's CommonJS build (ERR_REQUIRE_ESM, see #2711)
# and can force a change to its supported Node floor.
- dependency-name: "p-retry"
- dependency-name: "@types/node"
versions:
Expand Down
90 changes: 30 additions & 60 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions packages/web-api/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@
"@types/node": ">=20",
"@types/retry": "0.12.5",
"eventemitter3": "^5.0.1",
"p-queue": "^9",
"p-retry": "^8",
"p-queue": "^6.6.2",
"p-retry": "^4.6.2",
Comment on lines +56 to +57

@WilliamBergamin WilliamBergamin Aug 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏

"retry": "^0.13.1"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/webhook/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
"@slack/types": "^3.1.0",
"@types/node": ">=20",
"@types/retry": "0.12.5",
"p-retry": "^8",
"p-retry": "^4.6.2",
"retry": "^0.13.1"
},
"devDependencies": {
Expand Down