Port to 1.20.1#148
Open
crabsatellite wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR ports the GreekFantasy Minecraft mod from version 1.19.2 to 1.20.1, updating all necessary APIs and dependencies. The changes include version updates, language file additions, and comprehensive code migrations to accommodate breaking API changes in Minecraft 1.20.1.
- Updated Forge loader version from 43 to 47 and mod version from 19.2.6 to 20.1.0
- Migrated from deprecated/removed APIs (Material, Registry, DamageSource, etc.) to their 1.20.1 equivalents
- Added complete Japanese language support and updated Chinese translations
- Fixed a critical bug in structure modifier (minCount changed from -2 to 1)
Reviewed changes
Copilot reviewed 161 out of 164 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| modify_shipwreck.json | Fixed minCount from invalid -2 to valid 1 for siren spawning |
| zh_cn.json | Updated Chinese translations with new content and formatting fixes |
| ja_jp.json | Added complete Japanese language support |
| mods.toml | Updated version numbers and dependency requirements for 1.20.1 |
| Java files (multiple) | Migrated to 1.20.1 APIs: BlockPos.containing(), Material removal, DamageSource changes, Registry updates, ArmorItem.Type, etc. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…annotation in Pegasus
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completed the port to 1.20.1 and performed basic client-side testing. All major features appear to be working. Ready for further testing and review!