Repository navigation
[ENH] univariate MiniRocket via 2D input and float32/float64 kernels without casting - #6
Conversation
fkiraly
left a comment
There was a problem hiding this comment.
Looks great, the reuse is also good.
The only thing I am confused about is that the function names are now rocket vs minirocket, but both are, in fact, minirocket, just uni vs multivariate?
I am also confused about the following: suppose we pass an X of size (n, 1, d) to rocket_fit, how does this compare to passing the same X of size (n, d) to minirocket_fit, and so on?
Is this the same, or a different function?
If it is a different function, what exactly differs?
|
Thanks @fkiraly, good catch: they are the same function. For So I dropped the separate univariate functions. |
0a9100b to
f9b8e52
Compare
There was a problem hiding this comment.
Perfect. So I did suspect correctly that these were just minor variations of the same function! That already bothered me about the implementations in sktime.
One minor nit, you committed a uv.lock, I would recommend you add that to the gitignore and remove from the PR, or it accidentally ships with the package.
ae12d8b to
59c6d35
Compare
59c6d35 to
04d114b
Compare
Done by accident, indeed. I've added the file to the gitignore. |
Reference Issues/PRs
None.
What does this implement/fix? Explain your changes.
Adds univariate MiniRocket support to the existing compute API:
rocket_fit/rocket_transformnow accept a 2D(n_instances, n_timepoints)panel in addition to 3D. 2D input is the single-channel case(n_instances, 1, n_timepoints).MiniRocketandMiniRocketMultivariateproduce identical features on single-channel input.ValueError.transformand would drift from sktime.Does your contribution introduce a new dependency? If yes, which one?
No.
What should a reviewer concentrate their feedback on?
rocket_fit/rocket_transformis the preferred way to expose the univariate case.Any other comments?
2D output matches sktime
MiniRocketacross multiple seeds, kernel counts and dilation limits. 2D and(n, 1, d)input give identical parameters and features, including the threaded path.float64 and integer input give parameters and features identical to casting to float32 first.
PR checklist
For all contributions
For new estimators
🤖 Generated with Claude Code