Repository navigation
[DOC] Update v2 extension templates for forecaster API - #2484
BLVCK-MAMBA-6 wants to merge 35 commits into
Conversation
This reverts commit 663a893.
Co-authored-by: Faakhir30 <zahidfaakhir@gmail.com>
…in Baseforecaster and not using skbase, .predict() now returns TimeSeries
phoeenniixx
left a comment
There was a problem hiding this comment.
Thanks!
Can you please not remove the docstrings and todos instead update them, please follow the exisiting pattern and update the template based on it
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v2-dev #2484 +/- ##
=========================================
Coverage ? 88.41%
=========================================
Files ? 202
Lines ? 11683
Branches ? 0
=========================================
Hits ? 10329
Misses ? 1354
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Hi @phoeenniixx, I’ve restored the docstrings and TODOs and updated them for the new API, following the existing template pattern. Please take another look whenever you're chanced. Thank you. |
Reference Issues/PRs
Refs #2474. Stacked on #2434.
What does this implement/fix? Explain your changes.
Updates the extension templates to match the v2 forecaster API:
BaseForecastertemplate.BaseTimeSeriesDataModulehooks and inherits its constructor to preserve configuration when attaching data.This covers only the extension-template subtask of #2474.
What should a reviewer concentrate their feedback on?
Whether the templates correctly demonstrate the model, forecaster, and datamodule interfaces introduced in #2434.
The template changes are contained in commit
8aad6a2. The broader diff againstv2-devincludes changes inherited from #2434.Did you add any tests for the change?
No new automated tests were added.
The following checks passed for the changed templates:
The runtime configuration-cloning check was blocked during package import by
ModuleNotFoundError: No module named 'sklearn', so runtime behavior remains unverified.Any other comments?
This PR depends on #2434 and should merge after it.
The model and data-processing methods remain intentional fill-in placeholders.
PR checklist