Repository navigation
[BUG] Remove unnecessary test_integration skip for PatchTST_v2 - #2456
Merged
phoeenniixx merged 1 commit intoOct 9, 2026
Merged
Conversation
Remove the 'tests:skip_by_name' tag that excluded PatchTST_v2 from test_integration. The model passes all four parametrizations of the test, so the skip is unnecessary. Fixes sktime#2455 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
imjimit07
requested review from
benHeid,
fkiraly,
jdb78 and
phoeenniixx
as code owners
October 8, 2026 18:17
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2456 +/- ##
=======================================
Coverage ? 88.81%
=======================================
Files ? 218
Lines ? 11671
Branches ? 0
=======================================
Hits ? 10366
Misses ? 1305
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2455
PatchTST_v2was excluded fromtest_integrationvia thetests:skip_by_nametag in_patch_tst_pkg_v2.py. This PR removes the skip so the test runs again.Investigation
I set up the environment and ran the full v2 test suite for
PatchTST_v2. The model passes all tests — there is no underlying bug; the skip (added in the original model commit dd46c99) was simply unnecessary:The tag is removed entirely (rather than set to an empty list), matching the convention of all other v2 packages, none of which carry
tests:skip_by_name.Changes
"tests:skip_by_name": ["test_integration"]fromPatchTST_pkg_v2._tags