Skip to content

[BUG] Remove unnecessary test_integration skip for PatchTST_v2 - #2456

Merged
phoeenniixx merged 1 commit into
sktime:mainfrom
imjimit07:fix/patchtst-v2-test-integration-skip
Oct 9, 2026
Merged

phoeenniixx merged 1 commit into
sktime:mainfrom
imjimit07:fix/patchtst-v2-test-integration-skip

Conversation

@imjimit07

@imjimit07 imjimit07 commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Description

Fixes #2455

PatchTST_v2 was excluded from test_integration via the tests:skip_by_name tag in _patch_tst_pkg_v2.py. This PR removes the skip so the test runs again.

Investigation

I set up the environment and ran the full v2 test suite for PatchTST_v2. The model passes all tests — there is no underlying bug; the skip (added in the original model commit dd46c99) was simply unnecessary:

pytorch_forecasting/tests/test_all_v2/test_all_estimators_v2.py::TestAllPtForecastersV2::test_doctest_examples[PatchTST_v2] PASSED
pytorch_forecasting/tests/test_all_v2/test_all_estimators_v2.py::TestAllPtForecastersV2::test_integration[PatchTST_v2-0] PASSED
pytorch_forecasting/tests/test_all_v2/test_all_estimators_v2.py::TestAllPtForecastersV2::test_integration[PatchTST_v2-1] PASSED
pytorch_forecasting/tests/test_all_v2/test_all_estimators_v2.py::TestAllPtForecastersV2::test_integration[PatchTST_v2-2] PASSED
pytorch_forecasting/tests/test_all_v2/test_all_estimators_v2.py::TestAllPtForecastersV2::test_integration[PatchTST_v2-3] PASSED
pytorch_forecasting/tests/test_all_v2/test_all_estimators_v2.py::TestAllPtForecastersV2::test_checkpointing[PatchTST_v2-0..3] PASSED
pytorch_forecasting/tests/test_all_v2/test_all_estimators_v2.py::TestAllPtForecastersV2::test_predict_modes[PatchTST_v2-0..3] PASSED
pytorch_forecasting/tests/test_all_v2/test_all_estimators_v2.py::TestAllPtForecastersV2::test_pkg_linkage[PatchTST_v2-PatchTST_v2] PASSED

The tag is removed entirely (rather than set to an empty list), matching the convention of all other v2 packages, none of which carry tests:skip_by_name.

Changes

  • Removed "tests:skip_by_name": ["test_integration"] from PatchTST_pkg_v2._tags

Remove the 'tests:skip_by_name' tag that excluded PatchTST_v2 from
test_integration. The model passes all four parametrizations of the
test, so the skip is unnecessary.

Fixes sktime#2455

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@phoeenniixx phoeenniixx changed the title Remove unnecessary test_integration skip for PatchTST_v2 [BUG] Remove unnecessary test_integration skip for PatchTST_v2 Oct 8, 2026
@phoeenniixx phoeenniixx added the bug Something isn't working label Oct 8, 2026
@codecov

codecov Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@e437602). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2456   +/-   ##
=======================================
  Coverage        ?   88.81%           
=======================================
  Files           ?      218           
  Lines           ?    11671           
  Branches        ?        0           
=======================================
  Hits            ?    10366           
  Misses          ?     1305           
  Partials        ?        0           
Flag Coverage Δ
cpu 88.81% <ø> (?)
pytest 88.81% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@phoeenniixx phoeenniixx left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@phoeenniixx
phoeenniixx merged commit 0acb5a0 into sktime:main Oct 9, 2026
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Fixed/resolved

Development

Successfully merging this pull request may close these issues.

[BUG] PatchTSTv2 skips test_integration

2 participants