Repository navigation
[MNT] Add TestPyPI release workflow - #2454
seaic-mac-murchadha wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2454 +/- ##
=======================================
Coverage ? 88.81%
=======================================
Files ? 218
Lines ? 11671
Branches ? 0
=======================================
Hits ? 10366
Misses ? 1305
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
phoeenniixx
left a comment
There was a problem hiding this comment.
Thanks!
I think this is good, but before we merge, i think we need to create a ptf account in testpypi. Which will be something for @fkiraly i think
phoeenniixx
left a comment
There was a problem hiding this comment.
After some discussions with other core devs- There is a suggestion:
Is it possible that we keep just one release.yml file, there we build in a separate job and then based on the situation, we do pypi or testpypi release.
See how it is done in shap: https://github.com/shap/shap/blob/main/.github/workflows/build_wheels.yml
|
Thanks for the feedback @phoeenniixx. I'll rework the approach to use a shared build/testing path for PyPI and TestPyPI, with conditional publishing based on your |
ff59001 to
7b48816
Compare
|
Hi @phoeenniixx, Have adjusted the approach to use a single workflow which covers both PyPI and TestPyPI, based on the The automated test failure appears to be unrelated to the changes. |
Reference Issues/PRs
Resolves #2403 for the repo. A maintainer will still need to carry out the TestPyPI-side registration.
What does this implement/fix? Explain your changes.
Add
TestPyPIrelease workflow inpytorch-forecasting. This can be used to perform dry runs and experimental releases without publishing to production.What should a reviewer concentrate their feedback on?
Concentrate on
testpypi_release.yml, comparing it to its existing production release counterpart:pypi_release.yml.Did you add any tests for the change?
N/A - Workflow PR.
Testing was carried out:
twinechecks.actionlintreturned a0exit code, passing static validation.Any other comments?
A maintainer will need to configure a pending Trusted Publisher on TestPyPI prior to the workflow running successfully. I have verified there is not currently an existing
pytorch-forecastingproject on TestPyPI.PR checklist
pre-commit install.To run hooks independent of commit, execute
pre-commit run --all-files