Repository navigation
[DOC] Recommend uv and venv for developer setup - #2365
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2365 +/- ##
=======================================
Coverage ? 88.81%
=======================================
Files ? 218
Lines ? 11670
Branches ? 0
=======================================
Hits ? 10365
Misses ? 1305
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
phoeenniixx
left a comment
There was a problem hiding this comment.
Thanks! This is great
I have a doubt though - should we completely remove conda installation instructions? We can recommend uv but it should not mean that we remove installation instructions for conda ?
@fkiraly What do you think?
|
Yes, I agree that Conda should remain available as an installation option. This PR does not remove the general Conda installation instructions, the Conda command is still present near the top of My understanding was that |
|
I’ve now made the distinction explicit in the documentation: Conda remains documented as an installation option for the published package, while |
|
Hi @phoeenniixx, just following up on this. I clarified the Conda/uv distinction in All checks are passing. When you have a chance, could you please take another look? Thanks! |
|
Hi @phoeenniixx, just circling back on this one! I’ve updated the docs to clearly separate the workflows: All checks are passing and the branch is clean. Whenever you have a spare moment, I’d appreciate a re-review so we can get this merged. Thanks! |
|
And apologies for the late review. Thanks again for the help! |
|
Thank you so much, @phoeenniixx! No worries at all about the delay, I appreciate the review and approval. I'll definitely join the Discord server. As an AI/ML engineer, I'm really glad to dive deeper into Looking forward to working with everyone! |
|
Hi @phoeenniixx, it looks like the |
|
Thanks for the PR @BLVCK-MAMBA-6! |
|
Awesome! Thank you so much @phoeenniixx for merging this. Glad to contribute. |
Reference Issues/PRs
Fixes #2364.
What does this implement/fix? Explain your changes.
Updates the developer environment setup documentation to:
uvas the primary environment manager;venvas a fallback;devdependencies;The existing Conda package-installation guidance remains unchanged.
What should a reviewer concentrate their feedback on?
uvandvenvcommands are accurate across supported platforms.Did you add any tests for the change?
No automated tests were added because this is a documentation-only change.
The updated RST document was parsed successfully with
docutils, andgit diff --checkpassed.Any other comments?
None.
PR checklist