Repository navigation
[ENH] dataset reference layer with lazy sktime loaders - #170
aryamanDutta wants to merge 1 commit into
Conversation
|
Hey @amotl , I've opened this PR for issue #128, introducing a lightweight DatasetReference and DatasetRegistry abstraction with lazy loaders for the sktime datasets airline, lynx, and uschange. I've preserved the existing get_data() signature and added tests covering the new functionality and backward compatibility. All 12 dataset tests and 3 utility tests pass, and pre-commit checks are clean. Could you please review the implementation and let me know if any changes are needed? Thank you for your guidance! |
|
Thank you Aryaman. Because I am currently travelling, I'd like to defer the review to the other colleagues. 🙏 |
|
No worries @amotl ..Safe journey ! |
|
Hey @amotl, I investigated the two failing Python 3.10 Linux CI checks. Both fail with an |
Yes, please address that topic separately. Thank you! |
Reference Issues/PRs
Fixes #128.
What does this implement/fix? Explain your changes.
This PR introduces a lightweight dataset reference and registry layer in
pycaret.datasets.DatasetReferenceto encapsulate dataset metadata and loading behavior.DatasetRegistryto register and retrieve dataset references.sktimedatasetsairline,lynx, anduschange.get_data()while preserving its existing signature and local-file/remote-CSV resolution behavior.Does your contribution introduce a new dependency? If yes, which one?
No. This contribution introduces no new dependencies.
What should a reviewer concentrate their feedback on?
DatasetReferenceandDatasetRegistry.get_data().Did you add any tests for the change?
Yes. Added tests covering dataset reference loading, registry operations, tuple-to-DataFrame conversion, missing loaders and dependencies, loader errors, local-file precedence, custom addresses, and
save_copybehavior.Validation performed:
py -3.14 -m pytest tests/test_datasets.py -v- 12 passed.py -3.14 -m pytest tests/test_utils.py -v- 3 passed.Any other comments?
The implementation is currently focused on introducing the reference/registry abstraction and integrating the selected
sktimedatasets. Feedback on the design and intended scope of the migration is welcome.PR checklist
[ENH],[MNT],[DOC], or[BUG].