Skip to content

test(flex): strengthen contract coverage#241

Merged
KYBee merged 3 commits intodev/side-v2from
feature/flex-KYBee
Apr 22, 2026
Merged

test(flex): strengthen contract coverage#241
KYBee merged 3 commits intodev/side-v2from
feature/flex-KYBee

Conversation

@KYBee
Copy link
Copy Markdown
Contributor

@KYBee KYBee commented Apr 17, 2026 •
edited
Loading

요약

  • side 구현 기준으로 Flex 계약 다시 확인함
  • Storybook 옵션을 constants 기준으로 정리함
  • direction / align / justify / wrap 스토리 옵션을 constants 기준으로 일치시킴
  • Flex 테스트 범위를 계약 기준으로 보강함
  • normal 값 테스트 추가함
  • asChild 동작, style override, ref 전달 테스트 추가함
  • consumer 사용 패턴 기준 smoke test 추가함

테스트

  • packages/flex 단위 vitest 실행함
  • 전체 통과 확인함

close : #227

KYBee added 2 commits April 17, 2026 10:44
refactor(flex): align story options with constants
b7fa786 
- replace hardcoded story options with Flex constants
- keep Storybook controls aligned with the current contract values
- reduce the risk of drift between implementation and story definitions
test(flex): strengthen contract coverage
8b74f97 
- align tests with the current Flex contract in side
- use constants as the source of truth for direction, align, justify, and wrap cases
- add coverage for normal values, asChild behavior, style overrides, ref forwarding, and common consumer usage patterns
- verify the Flex test suite passes at the package level
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 17, 2026 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (2)
  • main
  • release/v1

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 8d34120a-e5ca-4e17-ac90-7ec4dca621fa

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/flex-KYBee

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 17, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9ecc525

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 17, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
packages/flex/src/Flex.test.tsx 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KYBee KYBee changed the title Flex contract verification and coverage test(flex): strengthen contract coverage Apr 17, 2026
@KYBee KYBee mentioned this pull request Apr 17, 2026
Closed
3 tasks
@minji0214
Copy link
Copy Markdown
Contributor

minji0214 commented Apr 17, 2026

옵션이 정리되니 보기 편안하네요 👍

osohyun0224
osohyun0224 approved these changes Apr 17, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@osohyun0224 osohyun0224 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생많으셨습니다 !!

Comment thread packages/flex/src/Flex.stories.tsx
direction: {
control: 'select',
options: ['row', 'column', 'row-reverse', 'column-reverse'],
options: FLEX_DIRECTIONS,
Copy link
Copy Markdown
Member

@osohyun0224 osohyun0224 Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

상수로 빼주니 아주 깔끔하군요 bb

@KYBee KYBee merged commit 8dbf884 into dev/side-v2 Apr 22, 2026
4 checks passed
@KYBee KYBee deleted the feature/flex-KYBee branch April 22, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@G-hoon G-hoon G-hoon approved these changes

@osohyun0224 osohyun0224 osohyun0224 approved these changes

@haedawn haedawn Awaiting requested review from haedawn

@Yeom-JinHo Yeom-JinHo Awaiting requested review from Yeom-JinHo

@minji0214 minji0214 Awaiting requested review from minji0214

@minjeeki minjeeki Awaiting requested review from minjeeki

@3o14 3o14 Awaiting requested review from 3o14

@froggy1014 froggy1014 Awaiting requested review from froggy1014

Assignees

@KYBee KYBee

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@KYBee @minji0214 @G-hoon @osohyun0224