chore: standardize catalog deps and chip package #210
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,8 @@ | ||
| import { defineConfig } from 'tsup'; | ||
|
|
||
| import defaultConfig from '../../tsup.config'; | ||
|
|
||
| export default defineConfig({ | ||
| ...defaultConfig, | ||
| external: ['react', '@radix-ui/react-slot', 'clsx'], | ||
|
Comment on lines
+6
to
7
There was a problem hiding this comment. 🧹 Nitpick | 🔵 Trivial 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "== Root tsup config =="
sed -n '1,220p' tsup.config.ts
echo
echo "== Chip tsup config =="
sed -n '1,220p' packages/chip/tsup.config.ts
echo
echo "== external declarations =="
rg -n --type=ts -C2 '\bexternal\s*:' tsup.config.ts packages/chip/tsup.config.tsRepository: sipe-team/side Length of output: 831 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "== All tsup.config.ts files in packages/* =="
fd 'tsup.config.ts' packages/
echo
echo "== External declarations in all package configs =="
fd 'tsup.config.ts' packages/ -x rg -l 'external' {}
echo
echo "== Show external patterns in all package configs =="
fd 'tsup.config.ts' packages/ -x sh -c 'echo "=== {} ==="; rg -A3 -B1 "external" {} || echo "(no external property)"'Repository: sipe-team/side Length of output: 875 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "== Chip package.json (dependencies section) =="
jq '.dependencies, .peerDependencies, .devDependencies' packages/chip/package.json
echo
echo "== Sample other package configs (button, avatar) =="
echo "--- button/tsup.config.ts ---"
cat packages/button/tsup.config.ts
echo
echo "--- avatar/tsup.config.ts ---"
cat packages/avatar/tsup.config.ts
echo
echo "== Verify if any package defines peerDependencies for react =="
fd 'package.json' packages/ -x jq -r 'select(.peerDependencies.react != null) | input_filename' 2>/dev/null | head -5Repository: sipe-team/side Length of output: 1048 Merge The Suggested refactor export default defineConfig({
...defaultConfig,
- external: ['react', '@radix-ui/react-slot', 'clsx'],
+ external: [
+ ...((defaultConfig as { external?: string[] }).external ?? []),
+ 'react',
+ '@radix-ui/react-slot',
+ 'clsx',
+ ],
});🤖 Prompt for AI Agents |
||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
웁스 - 이런게 있었네