docs: add AI tools configuration (Claude, Codex)#205
Conversation
froggy1014
requested review from
3o14,
G-hoon,
KYBee,
Yeom-JinHo,
haedawn,
minjeeki,
minji0214 and
osohyun0224
as code owners
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Walkthrough리포지터리에 Claude Code·Codex·MCP 설정과 개발자 문서가 추가되었습니다. Biome 자동 포맷 후크와 샌드박스·플러그인·모델 제한, Codex 기본 모델·승인 정책, Figma MCP 엔드포인트, Biome 스키마/설정 변경 및 devDependency 업그레이드가 포함됩니다. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.claude/settings.json:
- Around line 43-44: The JSON in .claude/settings.json is invalid due to a
trailing comma after the "PostToolUse" array in the "hooks" object; remove the
comma following the closing bracket of the "PostToolUse" array so the array ends
with ] (no comma), then validate the file (e.g., with a JSON linter) to ensure
"hooks" contains only that single property and the JSON parses correctly.
In @.codex/config.toml:
- Around line 14-18: The file is missing the [permissions.network] section so
the current sandbox configuration (sandbox_mode and [sandbox_workspace_write]
with network_access = true) permits unrestricted outbound access; add a new
[permissions.network] block named exactly "permissions.network" and set enabled
to true, mode to "limited", and provide an allowed_domains array containing
"registry.npmjs.org" and "npm.pkg.github.com" so network access is restricted to
those domains instead of being globally allowed.
In @.codex/hooks.json:
- Around line 5-10: The global Bash trigger ("matcher": "Bash") combined with
the command "pnpm biome check --write --unsafe --changed" is too broad and
applies destructive auto-fixes; change the hook to a narrower matcher (e.g.,
target only shell scripts or changed files instead of "Bash") and remove the
"--unsafe" flag from the command so it no longer applies potentially destructive
fixes; also consider invoking the repository-standard script (e.g., package.json
"format:biome" or "lint:biome") instead of calling biome with unsafe options to
align behavior with existing project scripts.
In `@CLAUDE.md`:
- Line 65: The MD037 lint warning is caused by unescaped asterisk patterns in
the list item "import 순서 강제: node → react → `@sipe-team/`* → `@vanilla-extract/`* →
`@radix-ui/`* → 외부 패키지 → 상대 경로 (그룹 사이 빈 줄)"; fix it by wrapping each glob-like
token containing '*' in inline code (e.g. change `@sipe-team/`*,
`@vanilla-extract/`*, `@radix-ui/`* to `@sipe-team/*`, `@vanilla-extract/*`,
`@radix-ui/*`) so the markdown linter no longer treats the asterisks as emphasis
(MD037).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: c0a01e0f-c08d-4974-98c6-f24487ab2cc7
📒 Files selected for processing (7)
.claude/settings.json.codex/config.toml.codex/hooks.json.gitignore.mcp.jsonAGENTS.mdCLAUDE.md
| ## 린팅 및 포맷팅 | ||
|
|
||
| - **Biome** (ESLint/Prettier가 아님) — 싱글 쿼트, 스페이스, 줄 너비 120자 | ||
| - import 순서 강제: node → react → @sipe-team/* → @vanilla-extract/* → @radix-ui/* → 외부 패키지 → 상대 경로 (그룹 사이 빈 줄) |
There was a problem hiding this comment.
마크다운 lint(MD037) 경고를 해소해 주세요.
Line [65]의 * 패턴이 강조 마커로 해석될 수 있습니다. 토큰을 코드 표기로 감싸면 경고를 없앨 수 있습니다.
수정 예시
-- import 순서 강제: node → react → `@sipe-team/`* → `@vanilla-extract/`* → `@radix-ui/`* → 외부 패키지 → 상대 경로 (그룹 사이 빈 줄)
+- import 순서 강제: `node` → `react` → `@sipe-team/*` → `@vanilla-extract/*` → `@radix-ui/*` → 외부 패키지 → 상대 경로 (그룹 사이 빈 줄)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - import 순서 강제: node → react → @sipe-team/* → @vanilla-extract/* → @radix-ui/* → 외부 패키지 → 상대 경로 (그룹 사이 빈 줄) | |
| - import 순서 강제: `node` → `react` → `@sipe-team/*` → `@vanilla-extract/*` → `@radix-ui/*` → 외부 패키지 → 상대 경로 (그룹 사이 빈 줄) |
🧰 Tools
🪛 markdownlint-cli2 (0.22.0)
[warning] 65-65: Spaces inside emphasis markers
(MD037, no-space-in-emphasis)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@CLAUDE.md` at line 65, The MD037 lint warning is caused by unescaped asterisk
patterns in the list item "import 순서 강제: node → react → `@sipe-team/`* →
`@vanilla-extract/`* → `@radix-ui/`* → 외부 패키지 → 상대 경로 (그룹 사이 빈 줄)"; fix it by
wrapping each glob-like token containing '*' in inline code (e.g. change
`@sipe-team/`*, `@vanilla-extract/`*, `@radix-ui/`* to `@sipe-team/*`,
`@vanilla-extract/*`, `@radix-ui/*`) so the markdown linter no longer treats the
asterisks as emphasis (MD037).
Yeom-JinHo
left a comment
Yeom-JinHo
left a comment
There was a problem hiding this comment.
🎭 Playwright MCP도 opt-in 문서 형태로 추가하면 좋을 것 같아요~!
|
|
||
| - **`packages/*`** — 개별 컴포넌트 패키지 (button, input, card, chip, skeleton 등) | ||
| - **`packages/tokens`** — 디자인 토큰 (색상, 간격, 타이포그래피, 라운딩, 그림자, z-index)을 vanilla-extract contract vars로 export | ||
| - **`packages/theme`** — vanilla-extract `assignInlineVars`를 사용한 ThemeProvider, 런타임 테마 전환 (4개 테마, 라이트 모드 기본) |
There was a problem hiding this comment.
투표를 보니까 release/v1이 main으로 머지할거같아서 release/v1 에서 /init을 했어요.
언제 release/v1을 합치실지 몰라서 어차피 다 새로운 파일들이기도하구, main을 target branch로 잡았습니다.
2 participants
Changes
Figma MCP 프로젝트 레벨에서의 MCP 추가
CLAUDE, AGENTS 초기화
To Reviewers
일단 먼저 초기화해두고, 작업하시는거 보면서 스킬 추가하거나 컨텍스트 깍아나가려고 합니다.
codex나 claude 세팅 값이나 연동을 우아하게 하는 방법아신다면 공유부탁드립니다. ㅎㅎ ...
Summary by CodeRabbit
Documentation
Chores