Repository navigation
docs(descriptor): the Linux requirements describe the registry build, then the release binary - #181
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The registry page describes the binary the registry builds and serves. The
hardware_requirementsLinux passage described this project's own release binary instead: x86-64 only and a glibc 2.34 floor.Facts: the registry builds linux_amd64 and linux_arm64 in its own image, and the amd64 binary it produced was measured with a GLIBC_2.14 symbol floor. x86-64, glibc 2.34, static libstdc++ and the CUDA build are properties of the release binary and the pip wheel. The libgomp.so.1 requirement is true of the registry build.
The passage now leads with what holds for the registry build (libgomp.so.1 at load time, with the apt/dnf hints and the exact LOAD error), states no glibc floor for it, and ends with one sentence for the release binary and the wheel (x86-64, glibc 2.34 or newer; the wheel bundles its own libgomp).
Only that passage changed, plus a dated entry in docs/RESEARCH_NOTES.md.
extension:,repo:, version, toolchains and excluded_platforms are untouched. docs/INSTALL.md already attributes the glibc floor to the release binary and the wheel, and already says the libgomp requirement applies to both builds, so it needed no change.