wasm: use vqtbl1q_s8 for swizzle on A64V8 for SIMD and relaxed SIMD - #1450
Merged
Merged
Conversation
mr-c
approved these changes
Sep 14, 2026
Collaborator
There was a problem hiding this comment.
LGTM; this is also what v8 does; thank you @jawj !
and likewise for wasmtime (used by Firefox) https://github.com/bytecodealliance/wasmtime/blob/817c58787f432bcdbbb87679011f72c5bc80dbda/winch/codegen/src/isa/aarch64/masm.rs#L1533
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch has
simde_wasm_i8x16_swizzleandsimde_wasm_i8x16_relaxed_swizzleusevqtbl1q_s8forSIMDE_ARM_NEON_A64V8_NATIVE.I haven't done comprehensive benchmarking, but some arguments in favour:
_mm_shuffle_epi8in ssse3.h already usesvqtbl1q_s8.In terms of what's emitted, here's Apple Clang 17.0.0 (clang-1700.6.4.2) with
-O3before —— and after —