silx.gui.plot: Fixed axis scales#4643
Open
t20100 wants to merge 3 commits into
Open
Conversation
t20100
commented
Jun 19, 2026
|
|
||
| _sigLogarithmicChanged = qt.Signal(bool) | ||
| """Signal emitted when axis scale has changed to or from logarithmic""" | ||
|
|
| for item in plot.getItems(): | ||
| item._updated() | ||
| plot._invalidateDataRange() | ||
| plot._setDirtyPlot() |
Member
Author
There was a problem hiding this comment.
make sure plot is updated when changing axis scale
| roi=True, | ||
| mask=True, | ||
| fit=False, | ||
| axisScales=False, |
Member
Author
There was a problem hiding this comment.
Moved as last argument to be fully backward compatible + renamed to be inline with other argument names
Comment on lines
+781
to
+786
| def getXAxisScaleButton(self) -> PlotToolButtons.XAxisScaleToolButton: | ||
| return self._xAxisScaleButton | ||
|
|
||
| def getYAxisScaleButton(self) -> PlotToolButtons.YAxisScaleToolButton: | ||
| return self._yAxisScaleButton | ||
|
|
Member
Author
There was a problem hiding this comment.
Make attributes added in #4529 private and expose them through methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<Module or Topic>: <Action> <Summary>(see contributing guidelines)PR summary
Some rework and fix spotted in plot axes scale support:
PlotWindowaxis scale buttons to make API backward compatible and place buttons next to action toggling log axes (Follow-up of silx.gui.plot.PlotWidget: Addedasinhscale for axes #4529)AI Disclosure