Skip to content

AbstractDataFileDialog: deleteLater models#4232

Open
kif wants to merge 2 commits into
silx-kit:mainfrom
kif:AbstractFileDialog_deleteLater
Open

AbstractDataFileDialog: deleteLater models#4232
kif wants to merge 2 commits into
silx-kit:mainfrom
kif:AbstractFileDialog_deleteLater

Conversation

@kif

@kif kif commented Mar 21, 2025

Copy link
Copy Markdown
Member

Addresses this bug in pyFAI-calib2:
silx-kit/pyFAI#2422

Checklist:


@kif kif requested review from t20100 and vallsv March 21, 2025 07:48
@kif

kif commented Mar 21, 2025

Copy link
Copy Markdown
Member Author

With this PR, I am really outside my comfort zone ...

@t20100

t20100 commented Jun 30, 2025

Copy link
Copy Markdown
Member

@kif, I don't remember, was this fixed in another way?

@kif

kif commented Jul 1, 2025

Copy link
Copy Markdown
Member Author

This bug is clearly related to PyQt5 where objects are deleted in the wrong order. It is not fixed in pyFAI because it uses this specific silx class. What occurs is that pyFAI-calib2 crashes randomly when using this file-dialog on steroids: the object gets deleted on the python side then Qt tries to access it (to delete it) and it no more exists. It is related to the tree model underneath, something like that. on the one hand, I have never seen the bug with PySide6, on the other, I know this workaround partially works but it is neither a silver-bullet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants