Allow scalar monitor#1221
Merged
Merged
Conversation
…, allow scalar monitor
woutdenolf
requested changes
Jun 23, 2026
| mvalue = dataObject.m[0][0] | ||
| if mvalue == 0: | ||
| raise ValueError("Do not divide by zero") | ||
| mdata = numpy.array([mvalue]) |
Collaborator
There was a problem hiding this comment.
Redundant but does seem to work unexpectedly. I would remove it.
Collaborator
Author
There was a problem hiding this comment.
OK. mdata = numpy.array([mvalue]) is useless.
But now I am not sure this part of code is reachable at all... it is not for HDF5 but for SPS. Have no idea if there monitor could be scalar. Probably? or should this block to be removed?
woutdenolf
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1218
convert scalar to
numpyarray (with a single value, no need to extend tolen(ydata))do not strip
ydataif monitor is scalarexplicitly handle scalar monitor for single monitor selection (in multi monitor selection it is already handled)
fix a small issue for multi monitor - before start iterating all monitors should have
len > 0not only first onedelete few lines which were related to Python2