Remove unused libraries from pyproject.toml#1111
Open
benjaminking wants to merge 1 commit into
Open
Conversation
mshannon-sil
requested changes
Jul 7, 2026
mshannon-sil
left a comment
mshannon-sil
left a comment
Collaborator
There was a problem hiding this comment.
@mshannon-sil reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on benjaminking).
pyproject.toml line 81 at r1 (raw file):
accelerate = "^1.0.0" transformers = "^4.48" optimum = "^1.16.0"
The reason we had optimum is because I was experimenting with bettertransformer, which requires that library. However, we determined that we can't use it because it doesn't support attention masks for padding. It would probably be good to just remove all the code related to bettertransformer if we're getting rid of optimum.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes several libraries from SILNLP that appear to be unused. Some of them are related to functionality we recently removed, but for others of them, it's not clear why they were included in the first place. I have run the full experiment pipeline and verified that it completed successfully with these libraries removed.
This change is