Fix LT-22351: OpenType/Graphite font features from style defaults now reach Dictionary Preview#1005

Draft

johnml1135 wants to merge 4 commits into

mainfrom

GitHub Actions / NUnit Tests failed Jul 13, 2026 in 0s

5 fail, 73 skipped, 4 228 pass in 10m 24s

1 files ±0 1 suites ±0 10m 24s ⏱️ +41s
4 306 tests ±0 4 228 ✅ ±0 73 💤 ±0 5 ❌ ±0
4 315 runs ±0 4 237 ✅ ±0 73 💤 ±0 5 ❌ ±0

Results for commit 5bc3727. ± Comparison against earlier commit dc5dedd.

Annotations

Check warning on line 0 in SIL.FieldWorks.XWorks.LcmWordGeneratorTests

github-actions / NUnit Tests

GenerateCharacterStyleFromLcmStyleSheet_NormalStyleOwnFontFeatures_BeatWritingSystemDefaultFontFeatures (SIL.FieldWorks.XWorks.LcmWordGeneratorTests) failed

test-results/Output/Debug/TestResults/runneradmin_runnervm1hos5_2026-07-13_19_33_37.trx [took 0s]

Raw output


            System.InvalidOperationException : Sequence contains more than one element   at System.Linq.Enumerable.Single[TSource](IEnumerable`1 source)
   at SIL.FieldWorks.XWorks.LcmWordGeneratorTests.GenerateCharacterStyleFromLcmStyleSheet_NormalStyleOwnFontFeatures_BeatWritingSystemDefaultFontFeatures() in D:\a\FieldWorks\FieldWorks\Src\xWorks\xWorksTests\LcmWordGeneratorTests.cs:line 416

Check warning on line 0 in SIL.FieldWorks.XWorks.CssGeneratorTests

github-actions / NUnit Tests

GenerateCssForConfiguration_NormalStyleOwnFontFeatures_BeatWritingSystemDefaultFontFeatures (SIL.FieldWorks.XWorks.CssGeneratorTests) failed

test-results/Output/Debug/TestResults/runneradmin_runnervm1hos5_2026-07-13_19_33_37.trx [took 0s]

Raw output


              Expected: String containing "span[lang='fr']{font-family:'Charis SIL',serif;font-feature-settings:"smcp" 1;"
  But was:  ".letHead{-moz-column-count:1;-webkit-column-count:1;column-count:1;clear:both;width:100%;}body{font-size:10pt;}span[lang='en']{font-family:'Charis SIL',serif;}span[lang='fr']{font-family:'Charis SIL',serif;font-feature-settings:"ss11" 1,"ss12" 1;}a{text-decoration:none;color:unset;}*[dir='ltr'], *[dir='rtl']{unicode-bidi:isolate;unicode-bidi:-ms-isolate;unicode-bidi:-moz-isolate;}.lexentry{clear:both;white-space:pre-wrap;}.lexentry{}.senses .sense{}.gloss> span{}"
   at SIL.FieldWorks.XWorks.CssGeneratorTests.GenerateCssForConfiguration_NormalStyleOwnFontFeatures_BeatWritingSystemDefaultFontFeatures() in D:\a\FieldWorks\FieldWorks\Src\xWorks\xWorksTests\CssGeneratorTests.cs:line 3262

1)    at SIL.FieldWorks.XWorks.CssGeneratorTests.GenerateCssForConfiguration_NormalStyleOwnFontFeatures_BeatWritingSystemDefaultFontFeatures() in D:\a\FieldWorks\FieldWorks\Src\xWorks\xWorksTests\CssGeneratorTests.cs:line 3262

Check warning on line 0 in SIL.FieldWorks.XWorks.CssGeneratorTests

github-actions / NUnit Tests

GenerateCssForConfiguration_DefaultFontFeaturesFromPersistedStyleRules_ReachPreviewCss (SIL.FieldWorks.XWorks.CssGeneratorTests) failed

test-results/Output/Debug/TestResults/runneradmin_runnervm1hos5_2026-07-13_19_33_37.trx [took 0s]

Raw output


              Expected: String containing "font-feature-settings:"smcp" 1"
  But was:  ".letHead{
		-moz-column-count:1;
		-webkit-column-count:1;
		column-count:1;
		clear:both;
		width:100%;
	}
a{
		text-decoration:none;
		color:unset;
	}
*[dir='ltr'], *[dir='rtl']{
		unicode-bidi:isolate;
		unicode-bidi:-ms-isolate;
		unicode-bidi:-moz-isolate;
	}
.sil.fieldworks.xworks.testrootclass> span{
		clear:both;
		white-space:pre-wrap;
	}
.sil.fieldworks.xworks.testrootclass> span{
	}
.sil.fieldworks.xworks.testrootclass> span span[lang='en']{
	}
.sil.fieldworks.xworks.testrootclass> span span[lang='fr']{
	}"
   at SIL.FieldWorks.XWorks.CssGeneratorTests.GenerateCssForConfiguration_DefaultFontFeaturesFromPersistedStyleRules_ReachPreviewCss() in D:\a\FieldWorks\FieldWorks\Src\xWorks\xWorksTests\CssGeneratorTests.cs:line 2465

1)    at SIL.FieldWorks.XWorks.CssGeneratorTests.GenerateCssForConfiguration_DefaultFontFeaturesFromPersistedStyleRules_ReachPreviewCss() in D:\a\FieldWorks\FieldWorks\Src\xWorks\xWorksTests\CssGeneratorTests.cs:line 2465

Check warning on line 0 in SIL.FieldWorks.XWorks.LcmWordGeneratorTests

github-actions / NUnit Tests

GenerateCharacterStyleFromLcmStyleSheet_DefaultFontFeaturesFromPersistedStyleRules_AddsWordTypographyProperties (SIL.FieldWorks.XWorks.LcmWordGeneratorTests) failed

test-results/Output/Debug/TestResults/runneradmin_runnervm1hos5_2026-07-13_19_33_37.trx [took 0s]

Raw output


              Expected: not null
  But was:  null
   at SIL.FieldWorks.XWorks.LcmWordGeneratorTests.AssertWordTypographyProperties(OpenXmlCompositeElement runProps, LigaturesValues ligaturesValue, NumberFormValues numberFormValue, NumberSpacingValues numberSpacingValue, Boolean contextualAlternativesValue, UInt32 stylisticSetId, Boolean stylisticSetValue) in D:\a\FieldWorks\FieldWorks\Src\xWorks\xWorksTests\LcmWordGeneratorTests.cs:line 457
   at SIL.FieldWorks.XWorks.LcmWordGeneratorTests.GenerateCharacterStyleFromLcmStyleSheet_DefaultFontFeaturesFromPersistedStyleRules_AddsWordTypographyProperties() in D:\a\FieldWorks\FieldWorks\Src\xWorks\xWorksTests\LcmWordGeneratorTests.cs:line 361

1)    at SIL.FieldWorks.XWorks.LcmWordGeneratorTests.AssertWordTypographyProperties(OpenXmlCompositeElement runProps, LigaturesValues ligaturesValue, NumberFormValues numberFormValue, NumberSpacingValues numberSpacingValue, Boolean contextualAlternativesValue, UInt32 stylisticSetId, Boolean stylisticSetValue) in D:\a\FieldWorks\FieldWorks\Src\xWorks\xWorksTests\LcmWordGeneratorTests.cs:line 457
   at SIL.FieldWorks.XWorks.LcmWordGeneratorTests.GenerateCharacterStyleFromLcmStyleSheet_DefaultFontFeaturesFromPersistedStyleRules_AddsWordTypographyProperties() in D:\a\FieldWorks\FieldWorks\Src\xWorks\xWorksTests\LcmWordGeneratorTests.cs:line 361

Check warning on line 0 in SIL.FieldWorks.FwCoreDlgControls.StyleInfoTests

github-actions / NUnit Tests

SaveToDB_DefaultFontFeatures_RoundTripsThroughRules (SIL.FieldWorks.FwCoreDlgControls.StyleInfoTests) failed

test-results/Output/Debug/TestResults/runneradmin_runnervm1hos5_2026-07-13_19_33_37.trx [took 0s]

Raw output


              Expected: True
  But was:  False
   at SIL.FieldWorks.FwCoreDlgControls.StyleInfoTests.SaveToDB_DefaultFontFeatures_RoundTripsThroughRules() in D:\a\FieldWorks\FieldWorks\Src\FwCoreDlgs\FwCoreDlgControls\FwCoreDlgControlsTests\StyleInfoTests.cs:line 218

1)    at SIL.FieldWorks.FwCoreDlgControls.StyleInfoTests.SaveToDB_DefaultFontFeatures_RoundTripsThroughRules() in D:\a\FieldWorks\FieldWorks\Src\FwCoreDlgs\FwCoreDlgControls\FwCoreDlgControlsTests\StyleInfoTests.cs:line 218

View more details on GitHub Actions