Repository navigation
Bump sigstore/cosign-installer from 3.10.0 to 4.0.0 - #1766
dependabot[bot] wants to merge 6 commits into
Conversation
eebdc33 to
a800f4f
Compare
a800f4f to
d24a9b4
Compare
d24a9b4 to
4782a02
Compare
|
I'll see if I can massage the workflows a bit to be compatible with current cosign ... |
|
At least two issues left:
|
| REKOR_URL=$(kubectl -n rekor-system get ksvc rekor -ojsonpath='{.status.url}') | ||
| echo "REKOR_URL=$REKOR_URL" >> $GITHUB_ENV | ||
|
|
||
| FULCIO_URL=$(kubectl -n fulcio-system get ksvc fulcio -ojsonpath='{.status.url}') | ||
| echo "FULCIO_URL=$FULCIO_URL" >> $GITHUB_ENV | ||
|
|
||
| #FULCIO_GRPC_URL=$(kubectl -n fulcio-system get ksvc fulcio-grpc -ojsonpath='{.status.url}') | ||
| #echo "FULCIO_GRPC_URL=$FULCIO_GRPC_URL" >> $GITHUB_ENV | ||
|
|
There was a problem hiding this comment.
it's not completely obvious to me that we're using the on-cluster versions of these services in this PR (looks like we might be reverting to PGI, which would not be what we'd want)?
There was a problem hiding this comment.
there is a
TUF_MIRROR=$(kubectl -n tuf-system get ksvc tuf -ojsonpath='{.status.url}')
cosign initialize --mirror $TUF_MIRROR --root ./root.json
earlier in the workflow which I believe should handle this -- but I agree the order of these steps seems strange (and the cosign UX design is dangerous: using a non-default instance should always be obvious).
I may have to rethink this altogether because the on-cluster tuf repo is missing the signingconfig file
Bumps [sigstore/cosign-installer](https://github.com/sigstore/cosign-installer) from 3.10.0 to 4.0.0. - [Release notes](https://github.com/sigstore/cosign-installer/releases) - [Commits](sigstore/cosign-installer@d7543c9...faadad0) --- updated-dependencies: - dependency-name: sigstore/cosign-installer dependency-version: 4.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Remove all uses of --rekor-url and --fulcio-url: looks like these should just work based on TUF now. Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
9658a98 to
ea50e46
Compare
The generated TUF repository does not contain the signing config file so we can't yet use it. As a workaround, revert the singing to use URLs from env variables. This still leaves the verify code using TUF so let's hope its contents and the env variables that signing now uses agree. Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
|
|
This should be ready to move forward. @bobcallaway updated one usage of cosign-installer already, we just should update the rest. |
I think this is all fixed, i dont see any non v4 usage of cosign-installer |
Bumps sigstore/cosign-installer from 3.10.0 to 4.0.0.
Release notes
Sourced from sigstore/cosign-installer's releases.
Commits
faadad0add support for cosign v3 releases (#201)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)