Repository navigation
chore: require core 0.6 and Node 24 for Vue - #17
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0d0cbc9833
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| description = "Ensure Node.js version is >= 20" | ||
| run = "node -e 'const major = Number(process.versions.node.split(\".\")[0]); if (major < 20) { console.error(`Node.js >= 20 is required (current: ${process.versions.node})`); process.exit(1); }'" | ||
| description = "Ensure Node.js version is >= 24" | ||
| run = "node -e 'const major = Number(process.versions.node.split(\".\")[0]); if (major < 24) { console.error(`Node.js >= 24 is required (current: ${process.versions.node})`); process.exit(1); }'" |
There was a problem hiding this comment.
For developers following the documented mise run ci flow, this check now rejects the previously supported Node 20, but [tools] still only provisions pnpm and does not activate/install Node 24. I checked the local mise --help, which describes that mise prepares the development environment before commands run; without adding node = "24" (or equivalent) to the tool list, mise users with Node 20 remain on their system Node and hit this failure instead of getting the required runtime.
Useful? React with 👍 / 👎.
Summary
Tests