rust(feat): add report tooling for external rules - #718
Merged
Conversation
Resolved conflicts:
- sift_mcp/src/server/mod.rs: union ReportTemplateService (this branch) with
UserService (main). Adopted main's app_uri rename and updated require_destructive
message.
- sift_test_util/src/mock/mod.rs: union report_templates + rule_evaluation (this
branch) with me + users (main).
- assets/docs/src/agents/mcp.md, assets/skills/{agents-md/AGENTS.md,claude-code/SKILL.md}:
accepted main's deletion (docs restructured into assets/skills/sift/**). Added
the three new report_templates tools to the discovery and writes lists in the
new assets/skills/sift/SKILL.md.
- Post-merge fixups: aligned report_templates tool descriptions with main's new
50/200 list defaults; updated test helper URIs to app.test.local now that the
server takes an app_uri directly instead of deriving from rest_uri.
Verified: cargo build -p sift_mcp and cargo test -p sift_mcp both clean, 267/267
tests pass. cargo check -p sift_cli fails due to a pre-existing if-let-guard
usage in main (PR #713) that requires a newer stable Rust than the local
toolchain — not merge-caused.
Brandon-Shippy
marked this pull request as ready for review
August 4, 2026 22:46
evan-sift
reviewed
Aug 4, 2026
evan-sift
reviewed
Aug 5, 2026
evan-sift
reviewed
Aug 5, 2026
evan-sift
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
archive state
Bundles in the follow bug fix:
list_runsandlist_test_reportswere missing guidance about the default of finding archived data is false.Verification
Testing of all the tools:
create_report_template:list_report_templates:update_report_template: