Skip to content

Push PkgbuildPatches, docs, fix bugs, correct typo. - #1

Merged
shssoichiro merged 4 commits into
shssoichiro:per-package-overridesfrom
ninetailedtori:pkgbuild-patches
Apr 19, 2026
Merged

Push PkgbuildPatches, docs, fix bugs, correct typo.#1
shssoichiro merged 4 commits into
shssoichiro:per-package-overridesfrom
ninetailedtori:pkgbuild-patches

Conversation

@ninetailedtori

Copy link
Copy Markdown

Signed-off-by: Toria <ninetailedtori@uwu.gal>
Signed-off-by: Toria <ninetailedtori@uwu.gal>
Comment thread src/config.rs
Comment thread src/config.rs
@kilo-code-bot

kilo-code-bot Bot commented Apr 18, 2026

Copy link
Copy Markdown

Code Review Summary

Status: 1 Issue Found | Recommendation: Address before merge

Fix these issues in Kilo Cloud

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 0
Issue Details (click to expand)

WARNING

File Line Issue
src/config.rs 1502 parse_patches_list() still does not trim each comma-separated item before parsing, so any patch after the first with a leading space is misparsed as a local path instead of a URL.
Other Observations (not in diff)

No additional issues found outside the diff.

Files Reviewed (1 file)
  • src/config.rs - 1 carried-forward issue

Reviewed by kimi-k2.5-0127 · 573,640 tokens

Signed-off-by: Toria <ninetailedtori@uwu.gal>
Comment thread src/install.rs
Comment thread src/config.rs Outdated
@shssoichiro

Copy link
Copy Markdown
Owner

Thanks, this looks useful! I don't see any significant issues with the code, and the addition of automated test cases is good.

@shssoichiro
shssoichiro merged commit cef8e8f into shssoichiro:per-package-overrides Apr 19, 2026
1 check passed
@ninetailedtori
ninetailedtori deleted the pkgbuild-patches branch April 19, 2026 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants