Repository navigation
fix(api): rate-limit authenticated routes by user id - #119
Merged
Merged
Conversation
Move rate limiting after authenticateJWT in createApiHandler and createMethodHandler so the default keyGenerator can bucket on req.user.id. Shared-NAT users no longer share one IP budget on requireAuth routes; public/auth tiers stay IP-keyed. Closes #89.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
authenticateJWTincreateApiHandlerandcreateMethodHandlerwhenrequireAuthis set.req.user.id(default keyGenerator), so shared-NAT users no longer share one IP budget.lib/utils/__tests__/apiHandler.test.tscovering order, per-user budgets, and public IP keying.Closes #89.
Test plan
npm run test:backend:run(642 passed incl. 6 new)