Repository navigation
fix(smart-input): revoke compress object URL; skip non-image previews - #118
Merged
Merged
Conversation
compressImageIfNeeded leaked a blob URL per large image (createObjectURL never revoked). Move helpers to lib/attachmentPreview and always revoke in try/finally. Gate data-URL previews to image/* so PDFs/videos are not base64-encoded into memory. Closes #104.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createObjectURLused by image compression in atry/finallyso large attachments no longer leak blob URLs.image/*files so PDFs/videos are not base64-encoded into memory.lib/attachmentPreview.tswith unit coverage for revoke-on-success, revoke-on-error, and non-image skip.Closes #104.
Test plan
npm run lintEnhancedTaskInput.filePreview.test.ts(8)npm run build