[16.0][ADD] add shopinvader_api_payment_provider_worldline - #102
Open
benwillig wants to merge 1 commit into
Open
[16.0][ADD] add shopinvader_api_payment_provider_worldline#102benwillig wants to merge 1 commit into
benwillig wants to merge 1 commit into
Conversation
paradoxxxzero
requested changes
Apr 28, 2026
Contributor
There was a problem hiding this comment.
I migrated this PR in #108 to replace shopinvader_api_payment_provider_sips and I tried to add unit test, please take a look @benwillig
| return payload | ||
| shopinvader_api_base_url = self.shopinvader_frontend_redirect_url | ||
| return_url = urljoin( | ||
| shopinvader_api_base_url, "/shopinvader/payment/providers/worldline/return" |
Contributor
There was a problem hiding this comment.
This is a wild assumption, in other providers we use:
shopinvader_api_payment_base_url = self.env.context.get(
"shopinvader_api_payment_base_url"
)
return_url = urljoin(shopinvader_api_payment_base_url, "worldline/return")| shopinvader_api_base_url, "/shopinvader/payment/providers/worldline/return" | ||
| ) | ||
| return_url_params = urls.url_encode({"provider_id": str(self.provider_id.id)}) | ||
| payload["hostedCheckoutSpecificInput"][ |
Contributor
There was a problem hiding this comment.
We should probably patch redirectPaymentMethodSpecificInput -> redirectionData -> returnUrl too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on OCA/account-payment#900