Skip to content

fix(transformers): handle YAML comment prefixes correctly for v3 #1266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AkaHarshit wants to merge 1 commit into
base: main
Choose a base branch
from
+21 −1
Open

fix(transformers): handle YAML comment prefixes correctly for v3 #1266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/transformers/src/shared/notation-transformer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import type { ShikiTransformer, ShikiTransformerContext } from '@shikijs/core'
import type { Element, Text } from 'hast'
import type { ParsedComments } from './parse-comments'
import { parseComments, v1ClearEndCommentPrefix } from './parse-comments'
import { parseComments, v1ClearEndCommentPrefix, v3ClearEndCommentPrefix } from './parse-comments'

export type MatchAlgorithm = 'v1' | 'v3'

Expand Down Expand Up @@ -67,6 +67,8 @@ export function createCommentNotationTransformer(

if (matchAlgorithm === 'v1')
comment.info[1] = v1ClearEndCommentPrefix(comment.info[1])
else if (matchAlgorithm === 'v3')
comment.info[1] = v3ClearEndCommentPrefix(comment.info[1])

const isEmpty = comment.info[1].trim().length === 0
// ignore comment node
Expand Down
6 changes: 6 additions & 0 deletions packages/transformers/test/fixtures/diff/1007.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 12 additions & 0 deletions packages/transformers/test/fixtures/diff/1007.yaml.output.html
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading