fix(vitepress-twoslash): scroll blocking on mobile viewports#1262
Open
micaiguai wants to merge 1 commit intoshikijs:mainfrom
Open
fix(vitepress-twoslash): scroll blocking on mobile viewports#1262micaiguai wants to merge 1 commit intoshikijs:mainfrom
micaiguai wants to merge 1 commit intoshikijs:mainfrom
Conversation
✅ Deploy Preview for shiki-matsu ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for shiki-next ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1262 +/- ##
=======================================
Coverage 89.66% 89.66%
=======================================
Files 79 79
Lines 3512 3512
Branches 1007 1009 +2
=======================================
Hits 3149 3149
Misses 327 327
Partials 36 36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xbetween the brackts.Description
Revert PR #1235
In the latest
vitepresswithtwoslashweb, the arrow is hidden due tocontent-visibility: auto, which createspaint containmentthat behaves likeoverflow: hidden. The scroll problem also exsit.So i use
position: fixedto ensure popper relative to viewport, don't affect scrollarea.Reproduce:
docs/.vitepress/theme/index.ts:11, the scroll problem is solved.strategy: 'fixed', it seems to work.Refers:
Linked Issues
PR #1235
Additional context
I also tried modify the dist code of
floating-vueto add throttle to scroll event, it's also works. but the repo is seem not maintain.