fix(cli): fall back to 'text' when file/URL has no extension and no -…#1248
Open
VeerShah41 wants to merge 1 commit intoshikijs:mainfrom
Open
fix(cli): fall back to 'text' when file/URL has no extension and no -…#1248VeerShah41 wants to merge 1 commit intoshikijs:mainfrom
VeerShah41 wants to merge 1 commit intoshikijs:mainfrom
Conversation
…-lang When processing local files or remote URLs, the language was resolved as: const lang = (options.lang || ext).toLowerCase() If both `options.lang` and `ext` are empty (e.g. `Makefile`, `Dockerfile`, or a URL like https://host/Dockerfile), `lang` becomes an empty string `''` which is passed directly to shiki and causes an error. The stdin code path already handles this correctly: const lang = options.lang || 'text' This commit aligns the file/URL path with the same fallback: const lang = (options.lang || ext || 'text').toLowerCase() Two regression tests are added covering: - A local file with no extension (Makefile) - A remote URL whose path has no file extension (Dockerfile)
✅ Deploy Preview for shiki-next ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for shiki-matsu ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1248 +/- ##
==========================================
+ Coverage 95.25% 95.26% +0.01%
==========================================
Files 92 92
Lines 8008 8032 +24
Branches 1704 1714 +10
==========================================
+ Hits 7628 7652 +24
Misses 374 374
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…-lang
When processing local files or remote URLs, the language was resolved as:
const lang = (options.lang || ext).toLowerCase()
If both
options.langandextare empty (e.g.Makefile,Dockerfile, or a URL like https://host/Dockerfile),langbecomes an empty string''which is passed directly to shiki and causes an error.The stdin code path already handles this correctly:
const lang = options.lang || 'text'
This commit aligns the file/URL path with the same fallback:
const lang = (options.lang || ext || 'text').toLowerCase()
Two regression tests are added covering:
xbetween the brackts.Description
Linked Issues
fixes #
Additional context