fix(transformers): correct stale JSDoc comments and remove unused export#1247
Open
VeerShah41 wants to merge 1 commit intoshikijs:mainfrom
Open
fix(transformers): correct stale JSDoc comments and remove unused export#1247VeerShah41 wants to merge 1 commit intoshikijs:mainfrom
VeerShah41 wants to merge 1 commit intoshikijs:mainfrom
Conversation
- notation-map: classActivePre/classActiveCode JSDoc said 'has diff' but this is a generic base transformer, not diff-specific. Changed to 'has a notation match'. - notation-error-level: same copy-paste issue — classActivePre/ classActiveCode JSDoc still said 'has diff' even though this transformer is for error/warning annotations. Fixed accordingly. - style-to-class: function-level JSDoc was 'Remove line breaks between lines' (copied verbatim from remove-line-breaks.ts). Replaced with an accurate description of what the transformer actually does. - parse-comments: removed exported v3ClearEndCommentPrefix which was defined but never called anywhere in the codebase (dead code). The sibling v1ClearEndCommentPrefix is correctly wired up and kept.
✅ Deploy Preview for shiki-matsu ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for shiki-next ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1247 +/- ##
==========================================
+ Coverage 95.25% 95.33% +0.08%
==========================================
Files 92 92
Lines 8008 8025 +17
Branches 1704 1715 +11
==========================================
+ Hits 7628 7651 +23
+ Misses 374 368 -6
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
notation-map: classActivePre/classActiveCode JSDoc said 'has diff' but this is a generic base transformer, not diff-specific. Changed to 'has a notation match'.
notation-error-level: same copy-paste issue — classActivePre/ classActiveCode JSDoc still said 'has diff' even though this transformer is for error/warning annotations. Fixed accordingly.
style-to-class: function-level JSDoc was 'Remove line breaks between lines' (copied verbatim from remove-line-breaks.ts). Replaced with an accurate description of what the transformer actually does.
parse-comments: removed exported v3ClearEndCommentPrefix which was defined but never called anywhere in the codebase (dead code). The sibling v1ClearEndCommentPrefix is correctly wired up and kept.
xbetween the brackts.Description
Linked Issues
fixes #
Additional context