feat(transformers): add classActiveCode option to transformerNotationWordHighlight#1201
Open
curiouscoder-cmd wants to merge 1 commit intoshikijs:mainfrom
Open
Conversation
…ionWordHighlight` Add the `classActiveCode` option to `transformerNotationWordHighlight` for consistency with other notation transformers (diff, focus, highlight, error-level). This allows adding a class to the <code> element when the code contains word highlight notations, complementing the existing `classActivePre` option.
✅ Deploy Preview for shiki-next ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for shiki-matsu ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1201 +/- ##
=======================================
Coverage 95.20% 95.20%
=======================================
Files 92 92
Lines 7922 7925 +3
Branches 1689 1690 +1
=======================================
+ Hits 7542 7545 +3
Misses 374 374
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
classActiveCodeoption totransformerNotationWordHighlightcloses #1203
Problem
The
transformerNotationWordHighlighttransformer was missing theclassActiveCodeoption that was recently added to other notation transformers:transformerNotationDifftransformerNotationFocustransformerNotationHighlighttransformerNotationErrorLevelThis caused inconsistency and limited styling options when word highlight notations were present in code blocks.
Solution
Added support for a new option:
classActiveCode.This enables applying a custom class to the
<code>element when word highlight notation is detected.Usage
Changes
Added classActiveCode option to TransformerNotationWordHighlightOptions interface
Implemented handling inside transformerNotationWordHighlight
Added 3 new tests for this functionality
Checklist
Code follows existing patterns
Tests added and passing (9 total tests for classActiveCode)
All transformer tests pass (60 tests)