Skip to content

fix(twoslash): correct custom-tags test by adding missing renderer line#1199

Open
Ayush123-e wants to merge 3 commits intoshikijs:mainfrom
Ayush123-e:fix/twoslash-custom-tags-test
Open

fix(twoslash): correct custom-tags test by adding missing renderer line#1199
Ayush123-e wants to merge 3 commits intoshikijs:mainfrom
Ayush123-e:fix/twoslash-custom-tags-test

Conversation

@Ayush123-e
Copy link
Copy Markdown

Description

This PR updates the custom-tags rich renderer test by adding a missing line that enables Twoslash to correctly process custom tag annotations, including:

  • @error
  • @warn
  • @log
  • @annotate

Without this line, the snapshot output did not match the renderer’s actual behavior, leading to inconsistent or failing tests.
This fix ensures the test suite accurately reflects the expected rendering output for custom tags.

Linked Issues

No linked issues.

Additional Context

  • This change affects only test files; it does not modify runtime behavior.
  • Ensures stable and correct snapshot output for custom-tag rendering.
  • Helps prevent false-negative test failures in future changes.

@netlify
Copy link
Copy Markdown

netlify bot commented Dec 3, 2025

Deploy Preview for shiki-matsu ready!

Name Link
🔨 Latest commit 945b3fa
🔍 Latest deploy log https://app.netlify.com/projects/shiki-matsu/deploys/69302dfa70c37b000891008d
😎 Deploy Preview https://deploy-preview-1199--shiki-matsu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify bot commented Dec 3, 2025

Deploy Preview for shiki-next ready!

Name Link
🔨 Latest commit 945b3fa
🔍 Latest deploy log https://app.netlify.com/projects/shiki-next/deploys/69302dfa200e370008cc4ad8
😎 Deploy Preview https://deploy-preview-1199--shiki-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.20%. Comparing base (61c87e8) to head (945b3fa).
⚠️ Report is 44 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1199   +/-   ##
=======================================
  Coverage   95.20%   95.20%           
=======================================
  Files          92       92           
  Lines        7922     7922           
  Branches     1689     1689           
=======================================
  Hits         7542     7542           
  Misses        374      374           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant