Update the test dependencies too - #826
Merged
Merged
Conversation
The earlier sweep ran `go get -u ./...`, which walks the imports of the named packages but not the imports of their tests, so ginkgo, gomega, pprof and semver stayed behind. `go get -u -t ./...` picks those up. armon/go-metrics stays at v0.4.1: the module renamed itself to hashicorp/go-metrics, so every later version declares a path that no longer matches how it is required here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependabot's first grouped pull request (#824) caught something the earlier sweep missed:
go get -u ./...walks the imports of the named packages but not the imports of their tests, so ginkgo, gomega, pprof and Masterminds/semver never moved.go get -u -t ./...picks them up, and this goes slightly further than #824 — ginkgo lands on 2.32.2 rather than 2.32.1.armon/go-metricsstays at v0.4.1 on purpose. The module renamed itself tohashicorp/go-metrics, so every version after v0.4.1 declares a module path that no longer matches how it is required here; the toolchain tries each one and falls back. Moving off it means switching to the new path, which is its own change.Verified locally: gofmt clean,
go vetclean, and the race suite green across all nine packages. CI now runs on hosted runners, so the rest proves itself on this pull request.