Repository navigation
Use Chess.com public API for profile detection - #3204
Open
Jelly-RayTian wants to merge 1 commit into
Open
Jelly-RayTian wants to merge 1 commit into
Jelly-RayTian wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use Chess.com's public player profile API and HTTP status codes for the Chess target, while retaining the profile URL in results. This proposes an alternative detection approach for the Chess portion of #3074; it does not address the other sites.
Validation
blueandmagnuscarlsenas claimed (HTTP 200), and a randomly generated username as available (HTTP 404), using the new probe.pytest -m 'not online' -q(14 passed).