Skip to content

fix(interpals): update errorMsg to current not-found text - #3198

Open
Tanzeel0Hussain wants to merge 1 commit into
sherlock-project:masterfrom
Tanzeel0Hussain:fix/interpals-false-positive
Open

Tanzeel0Hussain wants to merge 1 commit into
sherlock-project:masterfrom
Tanzeel0Hussain:fix/interpals-false-positive

Conversation

@Tanzeel0Hussain

Copy link
Copy Markdown

InterPals no longer serves the old "The requested user does not exist or is
inactive" text for missing users, so the message check never matched and
every username was reported as claimed (false positive).

Missing users now get HTTP 404 with a page that says "User not found".
Existing profiles (e.g. blue) return 200 and do not contain that text.

Changes:

  • errorMsg: "The requested user does not exist or is inactive" -> "User not found"

Validation (run locally):

  • pytest -m validate_targets_fp --chunked-sites "interpals": passed
  • pytest -m validate_targets_fn --chunked-sites "interpals": passed
  • pytest (default suite): passed
  • CLI check with --local: claimed user found, random user not found

@Tanzeel0Hussain

Copy link
Copy Markdown
Author

Heads-up: #3080 also fixes interpals (via status_code 404 instead of a new
errorMsg). Either approach works; I verified that missing users return 404
with a page containing "User not found", while real profiles do not. Happy
to close this PR in favor of #3080 if maintainers prefer that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants