Skip to content

fix(HackerNews): use Firebase API to eliminate false positives - #3192

Open
Skanda001 wants to merge 1 commit into
sherlock-project:masterfrom
Skanda001:fix-hackernews-false-positive
Open

Skanda001 wants to merge 1 commit into
sherlock-project:masterfrom
Skanda001:fix-hackernews-false-positive

Conversation

@Skanda001

@Skanda001 Skanda001 commented Nov 8, 2026 •

Copy link
Copy Markdown

HackerNews was on the false-positive exclusions list. The old entry
scraped the HTML profile page for "No such user." / "Sorry.", which is
fragile and produced false positives.

This switches detection to the public Firebase API:

  • urlProbe: /v0/user/{}/created.json
  • errorMsg: "null" (the API returns null for a missing user; a real
    user returns a numeric timestamp, so a username can't collide with
    the match string)
  • username_claimed: "pg" (blue does not exist on HN)

Validation:

  • pytest -m validate_targets --chunked-sites "HackerNews" -> 2 passed
  • pytest tests/test_manifest.py::test_validate_manifest_against_local_schema -> passed

"errorMsg": "null",
"errorType": "message",
"url": "https://news.ycombinator.com/user?id={}",
"urlMain": "https://news.ycombinator.com/",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useful to push files to another repository to be used, for example, via github
pages
inputs:
source-before-directory:
description: Source before directory from the origin directory
required: false
source-directory:
description: Source directory from the origin directory
required: true
destination-github-username:
description: Name of the destination username/organization
required: true
destination-repository-name:
description: Destination repository
required: true
user-email:
description: Email for the git commit
required: true
github-server:
description: 'Github server'
default: 'github.com'
required: false
user-name:
description: >-
[Optional] Name for the git commit. Defaults to the destination
username/organization name
required: false
default: ''
destination-repository-username:
description: '[Optional] Username/organization for the destination repository'
required: false
default: ''
target-branch:
description: >-
[Optional] set target branch name for the destination repository. Defaults
to "main"
default: main
required: false
commit-message:
description: >-
[Optional] commit message for the output repository. ORIGIN_COMMIT is
replaced by the URL@commit in the origin repo
default: Update from ORIGIN_COMMIT
required: false
target-directory:
description: '[Optional] The directory to wipe and replace in the target repository'
default: ''
required: false
create-target-branch-if-needed:

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking. I couldn’t find a specific change requested, as the comment text appears to be unrelated YAML from a different action. Could you clarify what you’d like changed in the HackerNews entry?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants