Repository navigation
Add geometry columns to batch CSV mode - #9
Merged
Merged
Conversation
Rows may now carry geometry, dim_D/dim_L/dim_W1/dim_W2/dim_r (metres), solve_for, and units — the same solve-or-check semantics as the single-intake --geometry flags, applied per row against that row's required gross area. Geometry-only columns without a geometry are rejected per row; shapes ignore dim_* columns they don't use, so one wide CSV can mix shapes. Table output gains a geometry column (solved dimension + provided area + PASS/FAIL); JSON rows gain a nested geometry object. Row errors stay isolated. Tests 42 -> 45. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the last open Python-package tracker item. Batch CSV rows may now carry
geometry,dim_D/dim_L/dim_W1/dim_W2/dim_r(metres),solve_for, andunits— the same solve-or-check semantics as the single-intake--geometryflags, applied per row against that row's required gross area.geometryvalue are rejected per row (typo protection, consistent with the unknown-column guard).dim_*columns they don't use, so one wide CSV can mix shapes.--jsonrows gain a nestedgeometryobject.unitsfails that row only.Test plan
uv run pytest: 45/45 passing (was 42) — solve + check + no-geometry rows, per-row error isolation (unknown shape, bad units, orphan dims), table and JSON outputuv run ruff check ./uv run mypyclean; smoke-tested the table output against a mixed-shape CSV🤖 Generated with Claude Code