Repository navigation
Fix HTML assessment validity, optimizer consistency, and session safety - #13
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HTML tool could report PASS for malformed inputs or unsupported velocity claims, recommend designs that failed intake checks, and partially overwrite a session when loading invalid JSON. This implements the fixes from the UI review in #12.
Validation: 46 Python tests, 34 JavaScript regression cases, and 13 Chromium browser workflows passed locally; ruff and strict mypy passed. Browser coverage includes save/load rollback, optimizer Apply, product undo, keyboard sizing/save, French locale, 320/390/640 px layouts, 200% CSS scaling, and default/assessed/multi-intake PDFs. The default Letter report is five pages instead of six. The affected print workflows were rerun after the final pagination fix.
Browser validation used Chromium; other engines and a human screen-reader session remain unverified.