Skip to content

fix: parse nested HTML safely and consolidate cache eviction - #193

Merged
shenald-dev merged 1 commit into
masterfrom
jules-11605602531846496384
Nov 6, 2026
Merged

shenald-dev merged 1 commit into
masterfrom
jules-11605602531846496384

Conversation

@shenald-dev

Copy link
Copy Markdown
Owner

Fixes a regex truncation bug in DuckDuckGoSearcher where nested tags caused the HTML parser to prematurely stop parsing a block, resulting in missed snippets or misalignment. Modifies blockRegex to properly use lookahead for the next result block or EOF.

Also centralizes and robustifies cache eviction logic in both DuckDuckGoSearcher and GoogleSearcher. The .catch() now properly chains to the stored Promise to guarantee self-eviction on errors, resolving dangling entry or stale error cache bugs. Updates agent journal files accordingly.


PR created automatically by Jules for task 11605602531846496384 started by @shenald-dev

Fixes a regex truncation bug in DuckDuckGoSearcher where nested tags caused the HTML parser to prematurely stop parsing a block, resulting in missed snippets or misalignment. Modifies blockRegex to properly use lookahead for the next result block or EOF.

Also centralizes and robustifies cache eviction logic in both DuckDuckGoSearcher and GoogleSearcher. The .catch() now properly chains to the stored Promise to guarantee self-eviction on errors, resolving dangling entry or stale error cache bugs. Updates agent journal files accordingly.

Co-authored-by: shenald-dev <245350826+shenald-dev@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@shenald-dev

Copy link
Copy Markdown
Owner Author

all checks passing and behavior looks right on point. shipping this.

@shenald-dev
shenald-dev merged commit 611751d into master Nov 6, 2026
1 check passed
@shenald-dev
shenald-dev deleted the jules-11605602531846496384 branch November 6, 2026 02:39
@google-labs-jules

Copy link
Copy Markdown
Contributor

all checks passing and behavior looks right on point. shipping this.

Acknowledged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant