Repository navigation
fix: parse nested HTML safely and consolidate cache eviction - #193
Conversation
Fixes a regex truncation bug in DuckDuckGoSearcher where nested tags caused the HTML parser to prematurely stop parsing a block, resulting in missed snippets or misalignment. Modifies blockRegex to properly use lookahead for the next result block or EOF. Also centralizes and robustifies cache eviction logic in both DuckDuckGoSearcher and GoogleSearcher. The .catch() now properly chains to the stored Promise to guarantee self-eviction on errors, resolving dangling entry or stale error cache bugs. Updates agent journal files accordingly. Co-authored-by: shenald-dev <245350826+shenald-dev@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
all checks passing and behavior looks right on point. shipping this. |
Acknowledged. |
Fixes a regex truncation bug in DuckDuckGoSearcher where nested tags caused the HTML parser to prematurely stop parsing a block, resulting in missed snippets or misalignment. Modifies blockRegex to properly use lookahead for the next result block or EOF.
Also centralizes and robustifies cache eviction logic in both DuckDuckGoSearcher and GoogleSearcher. The .catch() now properly chains to the stored Promise to guarantee self-eviction on errors, resolving dangling entry or stale error cache bugs. Updates agent journal files accordingly.
PR created automatically by Jules for task 11605602531846496384 started by @shenald-dev