Repository navigation
fix(release): guard ancestry filtering of pending commits - #116
Merged
Merged
Conversation
|
🚅 Deployed to the website-frontend-pr-116 environment in website-frontend 1 service not affected by this PR
|
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (3)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
railway-app
Bot
temporarily deployed
to
website-frontend / website-frontend-pr-116
October 9, 2026 01:08
Destroyed
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes regular release previews listing #113 again after it was released as v1.9.0 under a different commit SHA.
Uses ancestry filtering and skips merges that add no content, while retaining feature merges. Stops before creating a release if main is not an ancestor of develop, or if the merge-back includes earlier unreleased develop changes that filtering would hide.
Verification
bun test scripts/release-commits.test.tsto exercise duplicate release commits, feature merges, matching branches, diverged branches, and unreleased work preceding a merge-back.bun -e 'import { getRegularReleaseCommits } from "./scripts/release-commits"; console.log(await getRegularReleaseCommits())'.Confirmed locally: with main at v1.9.0 and develop at #115, the preview lists only #114 and #115. The fixture tests retain feature merges and reject both unsafe histories.
Summary by CodeRabbit