Repository navigation
chore: release v1.1057.0 - #12739
Merged
Merged
chore: release v1.1057.0#12739
Conversation
Co-authored-by: asset-generation-bot <action@github.com>
…ipts (#12735) Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
…ch regen (#12736) Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
#12738) Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Production changes - testing required
Phantom wallet supported chains
Removes Bitcoin, Sui and Monad from the Phantom wallet integration, since Phantom has deprecated them, and adds BNB Smart Chain. This fixes Phantom pairing: before this change, connecting always failed with "Phantom provider not found" and opened the install page even when the extension was installed. To test, connect Phantom with the extension installed and check that pairing works. Then check that EVM (including BNB Smart Chain) and Solana accounts and balances load, that no Bitcoin, Sui or Monad accounts appear, and that a send or swap on one EVM chain and on Solana works.
WalletConnect dApp sign-in
Fixes WalletConnect sign-in (SIWE / one-click auth) to dApps from non-native wallets. Before this, Venice.ai failed with "data is not an hex string", and KeepKey and Trezor One still couldn't sign in after that error was fixed. To test, connect ShapeShift to a dApp like venice.ai through WalletConnect and sign in with native, KeepKey, Trezor and one other non-native wallet such as Ledger or MetaMask. Also check that ordinary personal_sign message requests still show readable text and sign.
Asset data loading
Asset data loading is now versioned. A new deploy no longer wipes the saved assets, and the full asset file is only reloaded when its version changes, not on every page load. This also fixes held tokens showing a letter-avatar placeholder instead of their real icon on the first load after an asset update. To test, load the app with an existing session and check that portfolio token icons, names and balances look right on the first load with no placeholder avatars. Then reload and check that assets still appear without delay. Also do a quick check in a fresh or incognito profile.
Fixes, deps, and infra
Fixes the Cloudflare Pages deploy, which failed because the asset data file was over the size limit, and includes the regular asset data refresh. No testing required.
Dev/local only - no production testing required
No commits in this release are behind a feature flag that is off in production. The Phantom (
VITE_FEATURE_PHANTOM_WALLET), BNB Smart Chain, WalletConnect and asset flags are all on in production in the committed.env, and.env.productiondoesn't override any of them.