Repository navigation
chore: release v1.1043.0 - #12624
Merged
Merged
chore: release v1.1043.0#12624
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 task done
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All ten commits touch features that are ON in production (Portals swapper, Relay swapper, BOB Gateway, portfolio, trade input, public API). None map to a flagged-off feature, so the dev-only section is empty.
Production changes - testing required
Portals swapper quote accuracy and cross-chain tracking
Corrects Portals quote output amounts (previously inflated by up to 2.56%), partner fee, and gas limit, plus a display fix that applies to every swapper. Get a Portals quote (e.g. USDC Ethereum -> USDC Arbitrum), confirm the quoted receive amount matches what actually lands, and sanity-check the displayed fees and network fee across other swappers too.
#12625 then fixes cross-chain Portals swaps sitting Pending forever. Portals settle most cross-chain orders on Relay, which we never asked for status — only Axelar and Squid, neither of which indexes a Relay order. Relay is now queried first with Axelar and Squid kept as fallbacks. It also corrects the cross-chain sell amount: Portals withhold 0.01% of the requested input and the calldata pulls the reduced amount, so we now price, approve and display against what the transaction actually spends. Portals no longer override the action centre tx link, and an Axelar-routed swap is no longer marked complete off the origin tx alone.
Run a Portals cross-chain swap (e.g. Ethereum -> Base) end to end and confirm it moves to Complete rather than hanging Pending, that the action centre links to the block explorer, and that the amount that lands matches the quote. Relay status handling was extracted into shared helpers that both swappers now use, so regression-test Relay swaps too — status polling and the tracker link there should be unchanged.
BOB Gateway refund address
#12610 sends a
refundAddresson BOB Gateway quote requests when selling Bitcoin, but sourced it from the recipient — an EVM address on a BTC sell. BOB require a Bitcoin address there and rejected every such request withINVALID_REQUEST/base58 error, taking out all BTC sell rates and quotes. #12626 corrects it to the Bitcoin sending address, so the two commits ship as a net working change.Confirm a BTC -> EVM swap (e.g. BTC -> ETH) quotes and executes. Non-Bitcoin BOB Gateway routes (e.g. ETH -> BTC) are untouched and should be unchanged.
Portfolio scam token filtering
Adds an asset-id blacklist applied at portfolio ingestion and in tx history spam detection, seeded with two airdropped honeypots (AI Chain Coin / AICC and Privacy Coin / PVC). Verify those tokens no longer appear in portfolio balances or tx history, and that legitimate ERC20 balances and transaction history are unaffected.
Trade input balance selection
The sell-side balance now renders as a plain selectable element when there is nothing to pick from (single account or disabled dropdown), instead of a dimmed disabled button. Check that the balance is readable and copyable with a single account, and that multi-account wallets still get a working account dropdown.
Public API swap registration
Swap registration now sends
quotedAt(the quote's mint time, ISO 8601) to swap-service, and the redundantquoteIdfield plus the dead browser-side swap write were removed. Regression testing only for the web app: sanity-check that swaps still execute and appear correctly in swap/tx history; the payload change is API-side.Fixes, deps, and infra
Routine asset data regeneration and a translation sync from the International UX Workstream. No testing required.
Dev/local only - no production testing required
No commits in this release are behind a feature flag that is off in production.