Repository navigation
fix: refresh expired swap quotes before signing - #260
Open
0xApotheosis wants to merge 1 commit into
Open
0xApotheosis wants to merge 1 commit into
0xApotheosis wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reachedNext included review available in 43 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (17)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
0xApotheosis
force-pushed
the
fix/swap-quote-expiry
branch
from
September 8, 2026 03:12
7346d1c to
42e6f7e
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Delayed network switches/approvals could submit stale swap calldata. Refreshes before signing, rechecks allowance and requires acceptance when terms change. Deploy the backend before the frontend. A wallet dialog already opened can still outlive the quote.
Verification
Request Base USDC → Ethereum FOX with a test wallet. Delay switching or confirm an approval: expect a fresh quote. Mock changed amounts: require acceptance; cancel must stop. Mock refresh HTTP 502 or change wallets: no old transaction may reach signing. Leave the review past expiry: accepting should refresh again. Approval testing requires a transaction; reject the final swap if testing preparation only.
Unsigned Relay quote checked; wallet UI QA remains outstanding.