-
Notifications
You must be signed in to change notification settings - Fork 284
feat: add Ascend NPU support for VP-Drafter #619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
curnane-lab
wants to merge
11
commits into
sgl-project:main
Choose a base branch
from
curnane-lab:vp_drafter_npu
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
b2dc564
Add VP drafter training mode for DFlash
catnanami fb83909
Update specforge/core/dflash.py
catnanami 2962653
Update specforge/core/dflash.py
catnanami f11a5ed
Update specforge/core/dflash.py
catnanami dfe1166
fix formatting
6b7abec
fix scripts with shebang
031acc9
feat(vp_drafter): add Ascend NPU support for VP-Drafter
mingliangfu 6079975
fix lint
mingliangfu 7173938
Merge branch 'main' into vp_drafter_npu
curnane-lab 1ad167f
Merge branch 'main' into vp_drafter_npu
curnane-lab d5410db
Merge branch 'main' into vp_drafter_npu
curnane-lab File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| { | ||
| "architectures": [ | ||
| "DFlashDraftModel" | ||
| ], | ||
| "attention_bias": false, | ||
| "attention_dropout": 0.0, | ||
| "auto_map": { | ||
| "AutoModel": "dflash.DFlashDraftModel" | ||
| }, | ||
| "block_size": 16, | ||
| "bos_token_id": 151643, | ||
| "dflash_config": { | ||
| "mask_token_id": 151669, | ||
| "target_layer_ids": [1, 9, 17, 25, 33], | ||
| "training_mode": "vp_drafter", | ||
| "prefix_weight_base": 0.9 | ||
| }, | ||
| "dtype": "bfloat16", | ||
| "eos_token_id": 151645, | ||
| "head_dim": 128, | ||
| "hidden_act": "silu", | ||
| "hidden_size": 4096, | ||
| "initializer_range": 0.02, | ||
| "intermediate_size": 12288, | ||
| "layer_types": [ | ||
| "full_attention", | ||
| "full_attention", | ||
| "full_attention", | ||
| "full_attention", | ||
| "full_attention" | ||
| ], | ||
| "max_position_embeddings": 40960, | ||
| "max_window_layers": 5, | ||
| "model_type": "qwen3", | ||
| "num_attention_heads": 32, | ||
| "num_hidden_layers": 5, | ||
| "num_key_value_heads": 8, | ||
| "num_target_layers": 36, | ||
| "rms_norm_eps": 1e-06, | ||
| "rope_scaling": null, | ||
| "rope_theta": 1000000, | ||
| "sliding_window": null, | ||
| "tie_word_embeddings": false, | ||
| "use_cache": true, | ||
| "use_sliding_window": false, | ||
| "vocab_size": 151936 | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| { | ||
| "architectures": [ | ||
| "DFlashDraftModel" | ||
| ], | ||
| "attention_bias": false, | ||
| "attention_dropout": 0.0, | ||
| "auto_map": { | ||
| "AutoModel": "dflash.DFlashDraftModel" | ||
| }, | ||
| "block_size": 16, | ||
| "bos_token_id": 248043, | ||
| "dflash_config": { | ||
| "mask_token_id": 248070, | ||
| "target_layer_ids": [1, 8, 15, 22, 29], | ||
| "training_mode": "vp_drafter", | ||
| "prefix_weight_base": 0.9 | ||
| }, | ||
| "dtype": "bfloat16", | ||
| "eos_token_id": 248044, | ||
| "head_dim": 128, | ||
| "hidden_act": "silu", | ||
| "hidden_size": 2560, | ||
| "initializer_range": 0.02, | ||
| "intermediate_size": 9728, | ||
| "layer_types": [ | ||
| "full_attention", | ||
| "full_attention", | ||
| "full_attention", | ||
| "full_attention", | ||
| "full_attention" | ||
| ], | ||
| "max_position_embeddings": 262144, | ||
| "max_window_layers": 5, | ||
| "model_type": "qwen3", | ||
| "num_attention_heads": 32, | ||
| "num_hidden_layers": 5, | ||
| "num_key_value_heads": 8, | ||
| "num_target_layers": 32, | ||
| "pad_token_id": 248044, | ||
| "rms_norm_eps": 1e-06, | ||
| "rope_scaling": null, | ||
| "rope_theta": 10000000, | ||
| "sliding_window": null, | ||
| "tie_word_embeddings": true, | ||
| "transformers_version": "4.57.1", | ||
| "use_cache": true, | ||
| "use_sliding_window": false, | ||
| "vocab_size": 248320 | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| #!/bin/bash | ||
| # VP-Drafter (D2SD) training for Qwen3.5-4B on Ascend NPU | ||
| # Backend: HF + SDPA attention + HCCL distributed | ||
| # | ||
| # Required environment variables (override before invoking the script): | ||
| # TARGET_MODEL_PATH Path to Qwen3.5-4B weights | ||
| # TRAIN_DATA_PATH Path to the training jsonl | ||
|
|
||
| set -eu | ||
|
|
||
| SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd ) | ||
| ROOT_DIR=$(dirname "$SCRIPT_DIR") | ||
|
|
||
| : "${TARGET_MODEL_PATH:?Set TARGET_MODEL_PATH to the Qwen3.5-4B weights directory}" | ||
| : "${TRAIN_DATA_PATH:?Set TRAIN_DATA_PATH to the training jsonl file}" | ||
|
|
||
| NPU_DEVICES=${1:-0,1,2,3,4,5,6,7} | ||
| NUM_DEVICES=$(echo "$NPU_DEVICES" | tr ',' '\n' | wc -l) | ||
|
|
||
| export ASCEND_RT_VISIBLE_DEVICES=$NPU_DEVICES | ||
| export PYTORCH_NPU_ALLOC_CONF=max_split_size_mb:32 | ||
|
|
||
| torchrun \ | ||
| --standalone \ | ||
| --nproc_per_node "$NUM_DEVICES" \ | ||
| "$ROOT_DIR/scripts/train_dflash.py" \ | ||
| --target-model-path "$TARGET_MODEL_PATH" \ | ||
| --target-model-backend hf \ | ||
| --draft-config-path "$ROOT_DIR/configs/qwen3.5-4b-dta.json" \ | ||
| --train-data-path "$TRAIN_DATA_PATH" \ | ||
| --output-dir "$ROOT_DIR/outputs/qwen3.5-4b-dta-npu" \ | ||
| --num-epochs 6 \ | ||
| --batch-size 1 \ | ||
| --accumulation-steps 4 \ | ||
| --learning-rate 6e-4 \ | ||
| --warmup-ratio 0.04 \ | ||
| --max-grad-norm 1.0 \ | ||
| --max-length 1024 \ | ||
| --chat-template qwen3.5 \ | ||
| --attention-backend sdpa \ | ||
| --num-anchors 16 \ | ||
| --loss-decay-gamma 7.0 \ | ||
| --log-interval 50 \ | ||
| --save-interval 3000 \ | ||
| --report-to tensorboard \ | ||
| --block-size 16 \ | ||
| --embedding-key model.language_model.embed_tokens.weight \ | ||
| --trust-remote-code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| #!/bin/bash | ||
|
|
||
| SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd ) | ||
| ROOT_DIR=$(dirname $SCRIPT_DIR) | ||
| export TORCHINDUCTOR_CACHE_DIR=$ROOT_DIR/cache/compiled_kernels | ||
| export SPECFORGE_DATA_NUM_PROC=32 | ||
| NUM_GPUS=${1:-8} | ||
|
|
||
| ATTENTION_BACKEND=${2:-flex_attention} | ||
|
|
||
| torchrun \ | ||
| --standalone \ | ||
| --nproc_per_node $NUM_GPUS \ | ||
| $ROOT_DIR/scripts/train_dflash.py \ | ||
| --target-model-path Qwen/Qwen3-8B \ | ||
| --target-model-backend sglang \ | ||
| --draft-config-path $ROOT_DIR/configs/qwen3-8b-dta.json \ | ||
| --train-data-path $ROOT_DIR/cache/dataset/perfectblend_qwen3-8b_regen.jsonl \ | ||
| --output-dir $ROOT_DIR/outputs/qwen3-8b-dta-perfectblend \ | ||
| --num-epochs 6 \ | ||
| --batch-size 4 \ | ||
| --learning-rate 6e-4 \ | ||
| --warmup-ratio 0.04 \ | ||
| --max-grad-norm 1.0 \ | ||
| --max-length 3072 \ | ||
| --chat-template qwen \ | ||
| --attention-backend $ATTENTION_BACKEND \ | ||
| --loss-decay-gamma 7.0 \ | ||
| --log-interval 50 \ | ||
| --save-interval 1000 \ | ||
| --report-to wandb \ | ||
| --wandb-project specforge-qwen3-8b-dta \ | ||
| --block-size 16 \ | ||
| --num-anchors 512 \ | ||
| --wandb-name qwen3-8b-dta-perfectblend | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In bash scripts, it is highly recommended to double-quote all variable expansions (especially paths like
$ROOT_DIRand user inputs like$NUM_GPUSand$ATTENTION_BACKEND) to prevent word splitting and pathname expansion if they contain spaces or special characters. This is particularly important for paths that might be run in environments with non-standard directory names.