Selectable URL shortener for !path and !topo - #44
Merged
Conversation
… for !path and !topo map links
…er deterministic one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
shortener.pyreplaces the duplicated_shorten_syncincommands/path.pyandcommands/topo.py.[bot] url_shortenerselectsdagd(default, unchanged behaviour),sink(self-hosted, withsink_api_base+SINK_API_TOKENfrom[env]), ornone.POST /api/link/upsertunder a slug hashed from the target URL, so a repeated route re-uses one link rather than adding a row per invocation, and expire aftersink_link_ttl_days(default 30).sinkfalls back to da.gd on outage, misconfiguration, or rejection.Why
Sink caps target URLs at 2048 characters; a geojson.io map for a route past ~8 hops exceeds that, so the fallback is what stops long routes from silently losing their map link. The API token can't live in a git-tracked command script, hence
[env].Breaking changes
None. Default stays da.gd.
Verified end-to-end against a live Sink instance: create, upsert dedup, 30-day expiry, 302 fragment preservation, and the over-length fallback. 127 tests pass.