fix: contact aging destroyed by watermark reset + full-dump re-upserts - #41
Merged
Conversation
…t ages through full dumps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
sync_contactswatermark is now advance-only: an incremental response with no changed contacts carrieslastmod=0in its CONTACT_END frame; storing it reset the watermark, so the next dirty sync did a full ~350-contact dump.last_synced_atonly when the radio-sidelastmodactually changed, so full dumps (legit or accidental) can no longer stamp every contact with the same time.tests/test_contact_sync.py(4 tests, incl. a repro of the field log's zero-then-full-dump cycle); suite 110 passing.Why
Field log: sync at 15:07:25 returned 0 contacts (watermark zeroed), sync at 15:09:25 full-dumped 342 contacts — flattening
last_synced_at, the primary staleness signal for radio eviction, the DB contact-cap trim, and the Manage→Contacts 'last synced' column. The cycle repeated every time a no-op sync ran.Breaking changes
None. Existing flattened ages will re-differentiate as contacts genuinely change.
🤖 Generated with Claude Code