refactor: runtime-settings registry - #35
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
settings.pyregistry: each DB-persisted tunable (advert_interval_hours,command_delay,channel_retry_max) is one declarative entry (type, range, audit action, UI metadata, side-effect hook).load_runtime_settings()/set_runtime_setting().setting_list/get/set(validation + audit driven by the registry; audit action names unchanged).GET /api/settings+PUT /api/settings/{key}.!adm setting [key] [value]generic accessor (existing aliases unchanged).tests/test_settings_registry.py; all 13 tests pass.Why
Adding a tunable previously touched 5 layers; now it's a Config field + one registry entry.
Breaking changes
None user-facing; internal REST endpoints for delay/retry/interval moved to
/api/settings(bundled UI updated).🤖 Generated with Claude Code